ChatQnA demo yaml files integration between GMC and Oneclick #72
Conversation
Signed-off-by: zhlsunshine <huailong.zhang@intel.com> remove bin files
There was a problem hiding this comment.
let's delete the old one and make this chatQnA.yaml, what do you say?
There was a problem hiding this comment.
we will need two version: (one for gaudi, and one for xeon). for current one, Let's call it chatQnA-xeon.yaml
There was a problem hiding this comment.
Should we not put the yaml in GenAIExamples? Or are you thinking of a copy here for completeness. Is it possible instead to give a link to a file in another sub-project so we do not run into the issue of keeping things in sync?
microservices-connector/internal/controller/gmconnector_controller.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
we will need two version: (one for gaudi, and one for xeon). for current one, Let's call it chatQnA-xeon.yaml
microservices-connector/config/samples/gmcmanager/gmc-manager-rbac.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
| endpoint: /v1/embeddings | ||
| - name: TeiEmbedding | ||
| internalService: | ||
| nameSpace: chatqa | ||
| serviceName: tei-embedding-service | ||
| serviceName: tei-embedding-svc | ||
| config: | ||
| no_proxy: ".chatqa.svc.cluster.local" | ||
| http_proxy: "insert-your-http-proxy-here" |
There was a problem hiding this comment.
- we need remove all proxy setting in this sample
- rename this as chatQnA_xeon.yaml
- remove old chatQna.yaml
- remove old gmc_v1alpha3_gmconnector.yaml
| @@ -366,7 +349,10 @@ func (r *GMConnectorReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
| // get the router config | |||
| // r.Log.Info("Reconciling connector graph", "apiVersion", graph.APIVersion, "graph", graph.Name) | |||
| fmt.Println("Reconciling connector graph", "apiVersion", graph.APIVersion, "graph", graph.Name) | |||
|
|
|||
| err := reconcileResource("Configmap", req.NamespacedName.Namespace, "", nil, nil) | |||
There was a problem hiding this comment.
think we need add logic to select 'Configmap' or 'ConfigmapGaudi' based on current tgi svc setting
There was a problem hiding this comment.
As we discussed, let's keep this and then change them based on the discussion with Oneclick.
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
There was a problem hiding this comment.
Should we not put the yaml in GenAIExamples? Or are you thinking of a copy here for completeness. Is it possible instead to give a link to a file in another sub-project so we do not run into the issue of keeping things in sync?
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
Signed-off-by: zhlsunshine <huailong.zhang@intel.com>
|
Meged and related to #64 |
Description
ChatQnA demo yaml files integration between GMC and Oneclick:
template, creatinggmcmanagerandgmcrouterIssues
Issue#37
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
Oneclick
Tests
Describe the tests that you ran to verify your changes.