Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker build and push target for GMC #83

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

irisdingbj
Copy link
Collaborator

Description

set DOCKER_REGISTRY before hand

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

N/A

Tests

test locally

Signed-off-by: irisdingbj <shaojun.ding@intel.com>
Signed-off-by: irisdingbj <shaojun.ding@intel.com>
Copy link
Collaborator

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Copy link
Collaborator

@KfreeZ KfreeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lianhao lianhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daisy-ycguo daisy-ycguo merged commit 04d7f24 into opea-project:main Jun 6, 2024
5 checks passed
@irisdingbj irisdingbj deleted the gmcdocker branch June 6, 2024 15:46
KfreeZ pushed a commit to KfreeZ/GenAIInfra that referenced this pull request Jun 11, 2024
* add docker build and push target for GMC

Signed-off-by: irisdingbj <shaojun.ding@intel.com>
Signed-off-by: KfreeZ <kefei.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants