From 17c66a922a9e9a7e1c8ff504bf330593267890d9 Mon Sep 17 00:00:00 2001 From: Sanket Bhiogade Date: Mon, 29 Jan 2024 16:28:32 +0100 Subject: [PATCH 1/3] Adding version setting to "PyMPDATA" --- examples/setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/setup.py b/examples/setup.py index 8bb0b9484..e5c55d558 100644 --- a/examples/setup.py +++ b/examples/setup.py @@ -31,8 +31,8 @@ def get_long_description(): "ipywidgets", "seaborn", "numdifftools", - ] - + (["pyvinecopulib", "vtk"] if platform.architecture()[0] != "32bit" else []), + ], + # + (["pyvinecopulib", "vtk"] if platform.architecture()[0] != "32bit" else []), extras_require={ "tests": [ "pytest", From 708dc32b2ff6de8ddacc14f41371f185f5f2acaa Mon Sep 17 00:00:00 2001 From: Sanket Bhiogade Date: Wed, 14 Feb 2024 10:48:20 +0100 Subject: [PATCH 2/3] improving docstrings for diffusion kinetics --- .../physics/diffusion_kinetics/pruppacher_and_klett_2005.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/PySDM/physics/diffusion_kinetics/pruppacher_and_klett_2005.py b/PySDM/physics/diffusion_kinetics/pruppacher_and_klett_2005.py index 0b81d2996..8ca3852f7 100644 --- a/PySDM/physics/diffusion_kinetics/pruppacher_and_klett_2005.py +++ b/PySDM/physics/diffusion_kinetics/pruppacher_and_klett_2005.py @@ -1,12 +1,14 @@ """ -as in Pruppacher and Klett 2005 (eq. 13-14) -with reference to [Okuyama and Zung 1967](https://doi.org/10.1063/1.1840906) +as in [Pruppacher and Klett 2005, chapter 13](https://doi.org/10.1007/978-0-306-48100-0_13), +eq. (13-14) - with reference to [Okuyama and Zung 1967](https://doi.org/10.1063/1.1840906) """ import numpy as np class PruppacherKlett: + """D() stands for modified diffusivity, lamdaD stands for TODO""" + def __init__(self, _): pass From df159768912dada8d06af14a4a0a75027cd06434 Mon Sep 17 00:00:00 2001 From: Sanket Bhiogade Date: Wed, 14 Feb 2024 10:51:03 +0100 Subject: [PATCH 3/3] undo unintentional change --- examples/setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/setup.py b/examples/setup.py index e5c55d558..8bb0b9484 100644 --- a/examples/setup.py +++ b/examples/setup.py @@ -31,8 +31,8 @@ def get_long_description(): "ipywidgets", "seaborn", "numdifftools", - ], - # + (["pyvinecopulib", "vtk"] if platform.architecture()[0] != "32bit" else []), + ] + + (["pyvinecopulib", "vtk"] if platform.architecture()[0] != "32bit" else []), extras_require={ "tests": [ "pytest",