Full branch url #8
Conversation
Kelketek
force-pushed
the
full_branch_url
branch
3 times, most recently
from
ad087be to
6d65fbe
Compare
|
@antoviaque This is ready for review. |
| find -name '__pycache__' -type d -delete | ||
| find . -name '*.pyc' -delete | ||
| find . -name '*~' -delete | ||
| find . -name '__pycache__' -type d -delete |
There was a problem hiding this comment.
@Kelketek Why do we need the . here?
There was a problem hiding this comment.
Just happened to see this comment – for some non-GNU versions of find, the path is mandatory, and it looks like OSX ships with such a version of find.
There was a problem hiding this comment.
I see - does that mean that if we include this change, the rest can work natively on MacOS? I'm happy to include it regardless, but for the future I wonder if it's worth the effort to support multiple environments to run it, especially now that we have Vagrant integration.
There was a problem hiding this comment.
@antoviaque There's actually more changes that need doing to make it work properly on Mac OS X. I was just confused on how this ever worked, since I didn't think this syntax worked in Linux either.
Where's the vagrant info? I'd be happy to drop this change and just use that instead.
There was a problem hiding this comment.
@Kelketek You seem to have dropped it already so you might have found it in the meantime, but the latest master has the Vagrantfile: https://github.com/open-craft/opencraft/blob/master/Vagrantfile (cf the README also).
Kelketek
force-pushed
the
full_branch_url
branch
from
8371f10 to
eb65195
Compare
|
@antoviaque This is ready for a second look. |
Kelketek
force-pushed
the
full_branch_url
branch
from
eb65195 to
c216419
Compare
Kelketek
force-pushed
the
full_branch_url
branch
from
c216419 to
34782a7
Compare
| """ | ||
| Construct the URL for the pull request | ||
| """ | ||
| return 'https://github.com/{fork_name}/pull/{number}'.format(fork_name=self.fork_name, number=self.number) |
There was a problem hiding this comment.
# This is the 1st commit message: Re-writing circle.yml to store code coverage in CircleCI's workspace and collect them afterwards. Test run parallelization is used with environment variables instead of using custom test runner. # This is the commit message #2: Update Makefile message. # This is the commit message #3: Remove cov.html from cov.combine. # This is the commit message #4: Stop running all tests in all containers # This is the commit message #5: Cleanup # This is the commit message #6: Experiment with different IDs for each coverage report # This is the commit message #7: Gathering raw coverage from all steps # This is the commit message #8: Always copy coverage and log message when not found # This is the commit message #9: Log copying raw coverage files for debugging
Stores the full URL of a pull request in the instance model instead of just the number.
Also tweaks the makefile to fix issues I ran into when trying to use it.