feat: Implement Tracking in .NET #309 #327

chrfwow · 2024-12-04T16:03:00Z

This PR

Adds support for tracking

Related Issues

Closes #309

Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>

codecov · 2024-12-04T16:10:56Z

Codecov Report

Attention: Patch coverage is 65.51724% with 30 lines in your changes missing coverage. Please review.

Project coverage is 85.54%. Comparing base (70f847b) to head (23f4a06).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...c/OpenFeature/Model/TrackingEventDetailsBuilder.cs	59.18%	20 Missing ⚠️
src/OpenFeature/Model/TrackingEventDetails.cs	66.66%	8 Missing ⚠️
src/OpenFeature/FeatureProvider.cs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   86.66%   85.54%   -1.12%     
==========================================
  Files          34       36       +2     
  Lines        1387     1474      +87     
  Branches      147      150       +3     
==========================================
+ Hits         1202     1261      +59     
- Misses        153      183      +30     
+ Partials       32       30       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chrfwow · 2024-12-05T08:25:13Z

src/OpenFeature/Model/TrackingEventDetails.cs

+    /// <summary>
+    /// The index for the "targeting key" property when the EvaluationContext is serialized or expressed as a dictionary.
+    /// </summary>
+    internal const string TargetingKeyIndex = "targetingKey";


Do we need the TargetingKeyIndex here?

No, we would need instead a value index if anything, that would serve the same purpose when the TrackingEventDetails are serialized.

toddbaert · 2024-12-06T20:14:00Z

src/OpenFeature/FeatureProvider.cs

        public virtual Channel<object> GetEventChannel() => this.EventChannel;
+
+        /// <summary>
+        /// Use this method to track user interactions and the application state. The implementation of this method is optional.


Suggested change

/// Use this method to track user interactions and the application state. The implementation of this method is optional.

/// Track a user action or application state, usually representing a business objective or outcome. The implementation of this method is optional.

test/OpenFeature.Tests/OpenFeatureClientTests.cs

toddbaert · 2024-12-06T20:26:26Z

src/OpenFeature/Model/TrackingEventDetails.cs

+    /// <summary>
+    ///A predefined value field for the tracking details.
+    /// </summary>
+    public readonly double? Value;


Optional is good.

README.md

toddbaert

I think this is the only blocker.

askpt

I added a couple of concerns I found during the review. Otherwise, it seems good!

src/OpenFeature/OpenFeatureClient.cs

README.md

toddbaert

Approved, but consider @askpt 's points. I think it's fine to throw for whitespace event keys as well.

Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>

…ging

🤖 I have created a release *beep* *boop* --- ## [2.2.0](v2.1.0...v2.2.0) (2024-12-12) ### ✨ New Features * Feature Provider Enhancements- [#321](#321) ([#324](#324)) ([70f847b](70f847b)) * Implement Tracking in .NET [#309](#309) ([#327](#327)) ([cbf4f25](cbf4f25)) * Support Returning Error Resolutions from Providers ([#323](#323)) ([bf9de4e](bf9de4e)) ### 🧹 Chore * **deps:** update dependency fluentassertions to v7 ([#325](#325)) ([35cd77b](35cd77b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

## This PR Adds support for tracking ### Related Issues Closes open-feature#309 --------- Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com> Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.2.0](open-feature/dotnet-sdk@v2.1.0...v2.2.0) (2024-12-12) ### ✨ New Features * Feature Provider Enhancements- [open-feature#321](open-feature#321) ([open-feature#324](open-feature#324)) ([70f847b](open-feature@70f847b)) * Implement Tracking in .NET [open-feature#309](open-feature#309) ([open-feature#327](open-feature#327)) ([cbf4f25](open-feature@cbf4f25)) * Support Returning Error Resolutions from Providers ([open-feature#323](open-feature#323)) ([bf9de4e](open-feature@bf9de4e)) ### 🧹 Chore * **deps:** update dependency fluentassertions to v7 ([open-feature#325](open-feature#325)) ([35cd77b](open-feature@35cd77b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>

307: [FEATURE] Support Returning Error Resolutions from Providers

c444e52

Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>

chrfwow requested a review from a team as a code owner December 4, 2024 16:03

chrfwow changed the title ~~[FEATURE] Implement Tracking in .NET #309~~ feat Implement Tracking in .NET #309 Dec 4, 2024

chrfwow changed the title ~~feat Implement Tracking in .NET #309~~ feat: Implement Tracking in .NET #309 Dec 4, 2024

chrfwow force-pushed the logging branch from a289db9 to 76c812c Compare December 4, 2024 16:07

chrfwow commented Dec 5, 2024

View reviewed changes

toddbaert requested review from austindrenski, benjiro, cdonnellytx, kinyoklion, lukas-reining and thomaspoignant December 6, 2024 19:05

toddbaert reviewed Dec 6, 2024

View reviewed changes

test/OpenFeature.Tests/OpenFeatureClientTests.cs Show resolved Hide resolved

toddbaert reviewed Dec 6, 2024

View reviewed changes

README.md Show resolved Hide resolved

toddbaert self-requested a review December 6, 2024 20:33

toddbaert requested changes Dec 6, 2024

View reviewed changes

chrfwow requested a review from toddbaert December 9, 2024 07:58

askpt reviewed Dec 9, 2024

View reviewed changes

src/OpenFeature/OpenFeatureClient.cs Outdated Show resolved Hide resolved

src/OpenFeature/OpenFeatureClient.cs Outdated Show resolved Hide resolved

chrfwow requested a review from askpt December 9, 2024 11:01

lukas-reining reviewed Dec 9, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

chrfwow requested a review from lukas-reining December 9, 2024 15:36

toddbaert approved these changes Dec 9, 2024

View reviewed changes

lukas-reining approved these changes Dec 9, 2024

View reviewed changes

askpt approved these changes Dec 10, 2024

View reviewed changes

chrfwow force-pushed the logging branch from c8dc923 to 7a322fb Compare December 10, 2024 12:00

chrfwow added 2 commits December 10, 2024 13:01

feat: Implement Tracking in .Net open-feature#309

7a322fb

Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>

Merge branch 'open-feature:main' into main

628e573

Merge branch 'main' of https://github.com/chrfwow/dotnet-sdk into log…

23f4a06

…ging

chrfwow requested a review from toddbaert December 10, 2024 13:27

toddbaert approved these changes Dec 11, 2024

View reviewed changes

toddbaert merged commit cbf4f25 into open-feature:main Dec 11, 2024
13 of 15 checks passed

github-actions bot mentioned this pull request Dec 9, 2024

chore(main): release 2.2.0 #326

Merged

chrfwow deleted the logging branch December 12, 2024 06:20

kylejuliandev mentioned this pull request Jul 10, 2025

[FEATURE] Expose FeatureClient Track method in IFeatureClient interface #518

Closed

This was referenced Nov 27, 2025

Bump Grpc.AspNetCore and 8 others Jineshkumar1/opentelemetry-demo#165

Closed

Bump Grpc.AspNetCore and 8 others Jineshkumar1/opentelemetry-demo#167

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Implement Tracking in .NET #309 #327

feat: Implement Tracking in .NET #309 #327

Uh oh!

chrfwow commented Dec 4, 2024

Uh oh!

codecov bot commented Dec 4, 2024 •

edited

Loading

Uh oh!

chrfwow Dec 5, 2024

Uh oh!

toddbaert Dec 6, 2024

Uh oh!

toddbaert Dec 6, 2024

Uh oh!

Uh oh!

toddbaert Dec 6, 2024

Uh oh!

Uh oh!

toddbaert left a comment

Uh oh!

askpt left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toddbaert left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	/// Use this method to track user interactions and the application state. The implementation of this method is optional.
	/// Track a user action or application state, usually representing a business objective or outcome. The implementation of this method is optional.

feat: Implement Tracking in .NET #309 #327

feat: Implement Tracking in .NET #309 #327

Uh oh!

Conversation

chrfwow commented Dec 4, 2024

This PR

Related Issues

Uh oh!

codecov bot commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chrfwow Dec 5, 2024

Choose a reason for hiding this comment

Uh oh!

toddbaert Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

toddbaert Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

toddbaert Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

toddbaert left a comment

Choose a reason for hiding this comment

Uh oh!

askpt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toddbaert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 4, 2024 •

edited

Loading