-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Add optional CancellationToken parameter to SetProviderAsync #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add optional CancellationToken parameter to SetProviderAsync #638
Conversation
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Summary of ChangesHello @kylejuliandev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the OpenFeature API by introducing an optional CancellationToken parameter to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an optional CancellationToken to the SetProviderAsync methods, enabling cancellation of provider initializations. The changes are well-implemented, propagating the token through the repository to the provider. My review includes a suggestion to restore a helpful XML documentation comment that appears to have been removed accidentally, and a recommendation to add a test case to verify the cancellation behavior, which will enhance the robustness of the test suite.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
+ Coverage 93.20% 93.21% +0.01%
==========================================
Files 69 69
Lines 2987 2993 +6
Branches 359 359
==========================================
+ Hits 2784 2790 +6
Misses 143 143
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
This PR
Add new methods to pass CancellationTokens for
SetProviderAsync(FeatureProvider, CancellationToken)andSetProviderAsync(string, FeatureProvider, CancellationToken)so that cancellations can be propagated to Provider initialization method.Related Issues
Fixes #637
Notes
Follow-up Tasks
How to test