feat: Add Metric Hook Custom Attributes #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
+ Coverage 87.35% 87.73% +0.38%
==========================================
Files 47 48 +1
Lines 1827 1876 +49
Branches 190 196 +6
==========================================
+ Hits 1596 1646 +50
Misses 188 188
+ Partials 43 42 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
askpt
approved these changes
Jul 6, 2025
Member
askpt
left a comment
askpt
left a comment
There was a problem hiding this comment.
LGTM. Just a small note on a future improvements to the unit tests.
beeme1mr
reviewed
Jul 7, 2025
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
The feature looks great but I had a question about the docs. I also wonder if we should consider supporting something similar for traces.
Member
@beeme1mr That tracker idea might be something useful. Should we create an issue to track it if makes sense? |
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
arttonoyan
reviewed
Jul 8, 2025
beeme1mr
approved these changes
Jul 14, 2025
arttonoyan
approved these changes
Jul 14, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
…ce (#513) <!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> In #512 I needed to tweak the sample AspNetCore application to pass Hook options to the MetricsHook. I noticed that in order to pass the options I needed to use the delegate based approach, while discarding the `serviceProvider`, like: ```csharp featureBuilder.AddHostedFeatureLifecycle() .AddHook(_ => new MetricsHook(metricsHookOptions)) ``` It would be simpler and easier for devs to interact with a third overload that allows them to pass an instance of the hook that they want to interact with, like so: ```csharp featureBuilder.AddHostedFeatureLifecycle() .AddHook(new MetricsHook()) ``` ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> ### Notes <!-- any additional notes for this PR --> ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> ### How to test <!-- if applicable, add testing instructions under this section --> --------- Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
This was referenced Jul 31, 2025
This was referenced Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds new
MetricsHookOptionsandMetricsHookOptionsBuilderto optionally configure custom attributes that can be tagged on thefeature_flag.evaluation_success_totalmetric. Example usage:Screenshot below shows the AspNetCore sample application tagging the
feature_flag.evaluation_success_totalcounter with the specified dimensions.Related Issues
Fixes #509
Fixes #514
Notes
Follow-up Tasks
How to test