From cf4be2962d2eae9d769d25c955ac049fcecc1b10 Mon Sep 17 00:00:00 2001
From: Todd Baert <todd.baert@dynatrace.com>
Date: Thu, 22 Aug 2024 09:11:00 -0400
Subject: [PATCH] fixup: await verify

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
---
 .../memory/InMemoryProviderTest.java          | 27 ++++++++++---------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/test/java/dev/openfeature/sdk/providers/memory/InMemoryProviderTest.java b/src/test/java/dev/openfeature/sdk/providers/memory/InMemoryProviderTest.java
index e2c1e041d..6050885f0 100644
--- a/src/test/java/dev/openfeature/sdk/providers/memory/InMemoryProviderTest.java
+++ b/src/test/java/dev/openfeature/sdk/providers/memory/InMemoryProviderTest.java
@@ -5,6 +5,7 @@
 import dev.openfeature.sdk.EventDetails;
 import dev.openfeature.sdk.ImmutableContext;
 import dev.openfeature.sdk.OpenFeatureAPI;
+import dev.openfeature.sdk.ProviderState;
 import dev.openfeature.sdk.Value;
 import dev.openfeature.sdk.exceptions.FlagNotFoundError;
 import dev.openfeature.sdk.exceptions.ProviderNotReadyError;
@@ -27,6 +28,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.awaitility.Awaitility.await;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.argThat;
 import static org.mockito.Mockito.mock;
@@ -45,15 +47,16 @@ class InMemoryProviderTest {
     void beforeEach() {
         Map<String, Flag<?>> flags = buildFlags();
         provider = spy(new InMemoryProvider(flags));
-        OpenFeatureAPI.getInstance().onProviderConfigurationChanged(eventDetails -> {});
+        OpenFeatureAPI.getInstance().onProviderConfigurationChanged(eventDetails -> {
+        });
         OpenFeatureAPI.getInstance().setProviderAndWait(provider);
         client = OpenFeatureAPI.getInstance().getClient();
         provider.updateFlags(flags);
         provider.updateFlag("addedFlag", Flag.builder()
-            .variant("on", true)
-            .variant("off", false)
-            .defaultVariant("on")
-            .build());
+                .variant("on", true)
+                .variant("off", false)
+                .defaultVariant("on")
+                .build());
     }
 
     @SneakyThrows
@@ -85,10 +88,9 @@ void getDoubleEvaluation() {
     @Test
     void getObjectEvaluation() {
         Value expectedObject = new Value(mapToStructure(ImmutableMap.of(
-            "showImages", new Value(true),
-            "title", new Value("Check out these pics!"),
-            "imagesPerPage", new Value(100)
-        )));
+                "showImages", new Value(true),
+                "title", new Value("Check out these pics!"),
+                "imagesPerPage", new Value(100))));
         assertEquals(expectedObject, client.getObjectValue("object-flag", new Value(true)));
     }
 
@@ -112,7 +114,8 @@ void shouldThrowIfNotInitialized() {
         InMemoryProvider inMemoryProvider = new InMemoryProvider(new HashMap<>());
 
         // ErrorCode.PROVIDER_NOT_READY should be returned when evaluated via the client
-        assertThrows(ProviderNotReadyError.class, ()-> inMemoryProvider.getBooleanEvaluation("fail_not_initialized", false, new ImmutableContext()));
+        assertThrows(ProviderNotReadyError.class,
+                () -> inMemoryProvider.getBooleanEvaluation("fail_not_initialized", false, new ImmutableContext()));
     }
 
     @SuppressWarnings("unchecked")
@@ -126,8 +129,8 @@ void emitChangedFlagsOnlyIfThereAreChangedFlags() {
 
         provider.updateFlags(flags);
 
-        verify(handler, times(1))
-                .accept(argThat(details -> details.getFlagsChanged().isEmpty()));
+        await().untilAsserted(() -> verify(handler, times(1))
+                .accept(argThat(details -> details.getFlagsChanged().isEmpty())));
     }
 
     @Test