Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added an automatic module name (#362) #363

Merged
merged 2 commits into from
Mar 28, 2023
Merged

fix: added an automatic module name (#362) #363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c7e6cf
fix: added an automatic module name (#362)
ARobertsCollibra Mar 28, 2023
66a2eaf
derive module name
Kavindu-Dodan Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<junit.jupiter.version>5.9.2</junit.jupiter.version>
<!-- exclusion expression for integration tests -->
<testExclusions>**/integration/*.java</testExclusions>
<module-name>${groupId}.${artifactId}</module-name>
</properties>

<name>OpenFeature Java SDK</name>
Expand Down Expand Up @@ -349,6 +350,18 @@
</plugin>
<!-- End publish to maven central -->

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>3.3.0</version>
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>${module-name}</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
</plugin>
<!-- Begin source & javadocs being generated -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down