-
Notifications
You must be signed in to change notification settings - Fork 49
feat: query-style, generic useFlag hook #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
Apr 2, 2024
toddbaert
commented
Apr 2, 2024
c47005e to
92262fc
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Apr 2, 2024
toddbaert
commented
Apr 2, 2024
toddbaert
commented
Apr 2, 2024
juanparadox
reviewed
Apr 2, 2024
Member
juanparadox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments 😄
juanparadox
reviewed
Apr 2, 2024
Co-authored-by: Juan Bernal <juanxwtf@gmail.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
5933698 to
ffaad95
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
juanparadox
approved these changes
Apr 2, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Apr 2, 2024
toddbaert
commented
Apr 2, 2024
moredip
approved these changes
Apr 2, 2024
Member
moredip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woop!
Co-authored-by: Pete Hodgson <github@thepete.net> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Pete Hodgson <github@thepete.net> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Pete Hodgson <github@thepete.net> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
beeme1mr
approved these changes
Apr 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.4-experimental](react-sdk-v0.2.3-experimental...react-sdk-v0.2.4-experimental) (2024-04-03) ### ✨ New Features * query-style, generic useFlag hook ([#897](#897)) ([5c17b8d](5c17b8d)) ### 🔄 Refactoring * dir restructure ([#894](#894)) ([ce9f65c](ce9f65c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
useFlaghook. This hook:const { value: newMessage, isError, reason, errorCode, isAuthoritative, type } = useFlag('new-message', true);This PR fixes some type bugs as well, and adds to the readme.
DEPENDS ON: #898