fix: object client methods can receive dict or list as default_value (#…

…134) Signed-off-by: Federico Bond <federicobond@gmail.com>
open-feature · Jul 6, 2023 · 291581f · 291581f
1 parent d31b531
commit 291581f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/open_feature/open_feature_client.py b/open_feature/open_feature_client.py
@@ -182,7 +182,7 @@ def get_float_details(
     def get_object_value(
         self,
         flag_key: str,
-        default_value: dict,
+        default_value: typing.Union[dict, list],
         evaluation_context: typing.Optional[EvaluationContext] = None,
         flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
     ) -> dict:
@@ -197,7 +197,7 @@ def get_object_value(
     def get_object_details(
         self,
         flag_key: str,
-        default_value: dict,
+        default_value: typing.Union[dict, list],
         evaluation_context: typing.Optional[EvaluationContext] = None,
         flag_evaluation_options: typing.Optional[FlagEvaluationOptions] = None,
     ) -> FlagEvaluationDetails:

diff --git a/tests/test_open_feature_client.py b/tests/test_open_feature_client.py
@@ -61,6 +61,11 @@ def test_should_get_flag_value_based_on_method_type(
             },
             "get_object_details",
         ),
+        (
+            list,
+            ["string1", "string2"],
+            "get_object_details",
+        ),
     ),
 )
 def test_should_get_flag_detail_based_on_method_type(