fix: return correct type object in OpenFeatureClient._create_provider_evaluation #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobond
force-pushed
the
fix-provider-evaluation
branch
3 times, most recently
from
1872238 to
a4b0f17
Compare
…_evaluation Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
fix-provider-evaluation
branch
from
a4b0f17 to
c9367cb
Compare
federicobond
changed the title
beeme1mr
requested review from
thomaspoignant,
jamescarr,
hlipsig,
tcarrio and
toddbaert
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 93.09% 93.11% +0.01%
==========================================
Files 20 20
Lines 362 363 +1
==========================================
+ Hits 337 338 +1
Misses 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thomaspoignant
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_create_provider_evaluationmethod is declared as returning aFlagEvaluationDetailsbut actually returned theFlagResolutionDetailsdirectly from the provider.With this change, a
FlagEvaluationDetailsobject is created from the resolution details aligning the implementation with the spec and the declared types.Similar code can found in the Java SDK:
https://github.com/open-feature/java-sdk/blob/9ddc9f1cb2c85c2d096a493342e429120ff36e92/src/main/java/dev/openfeature/sdk/OpenFeatureClient.java#L134