feat: implement api-level hooks #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobond
force-pushed
the
api-hooks
branch
4 times, most recently
from
cda5e95 to
1aa9af4
Compare
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 93.02% 93.21% +0.18%
==========================================
Files 20 21 +1
Lines 373 383 +10
==========================================
+ Hits 347 357 +10
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
federicobond
force-pushed
the
api-hooks
branch
2 times, most recently
from
9a65b07 to
c6b1a40
Compare
tcarrio
approved these changes
Jul 8, 2023
beeme1mr
approved these changes
Jul 10, 2023
Kavindu-Dodan
approved these changes
Jul 10, 2023
Signed-off-by: Federico Bond <federicobond@gmail.com>
|
Rebased on top of latest |
toddbaert
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Implements API-level hooks as defined in the spec.
Related Issues
Resolves #72
Follow-up Tasks
Additional testing around hook evaluation for the OpenFeatureClient is necessary but I wanted to avoid scope creep for this pull request.