Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement get_provider_metadata for requirement 1.1.5 #140

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

federicobond
Copy link
Member

This PR

Implements requirement 1.1.5:

The API MUST provide a function for retrieving the metadata field of the configured provider.

@federicobond federicobond changed the title feat: implement get_provider metadata for requirement 1.1.5 feat: implement get_provider_metadata for requirement 1.1.5 Jul 8, 2023
@federicobond federicobond force-pushed the feat/get-provider-metadata branch from 26597ca to 46bbcd3 Compare July 8, 2023 05:17
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #140 (d4f1e9a) into main (7fe511f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   93.21%   93.26%   +0.05%     
==========================================
  Files          21       21              
  Lines         383      386       +3     
==========================================
+ Hits          357      360       +3     
  Misses         26       26              
Flag Coverage Δ
unittests 93.26% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
open_feature/open_feature_api.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@federicobond federicobond force-pushed the feat/get-provider-metadata branch from 46bbcd3 to 25ed8ef Compare July 10, 2023 16:01
Signed-off-by: Federico Bond <federicobond@gmail.com>
@federicobond federicobond force-pushed the feat/get-provider-metadata branch from 25ed8ef to d4f1e9a Compare July 10, 2023 17:35
@beeme1mr beeme1mr merged commit 695da28 into open-feature:main Jul 10, 2023
federicobond added a commit to federicobond/python-sdk that referenced this pull request Jul 11, 2023
…ture#140)

Signed-off-by: Federico Bond <federicobond@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants