Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement client get_metadata for requirement 1.2.2 #141

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

federicobond
Copy link
Member

This PR

Implements requirement 1.2.2:

The client interface MUST define a metadata member or accessor, containing an immutable name field or accessor of type string, which corresponds to the name value supplied during client creation.

Signed-off-by: Federico Bond <federicobond@gmail.com>
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #141 (1394102) into main (292a0df) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   92.91%   93.02%   +0.11%     
==========================================
  Files          20       20              
  Lines         367      373       +6     
==========================================
+ Hits          341      347       +6     
  Misses         26       26              
Flag Coverage Δ
unittests 93.02% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
open_feature/open_feature_client.py 95.87% <100.00%> (+0.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beeme1mr beeme1mr merged commit 571f5eb into open-feature:main Jul 10, 2023
@federicobond federicobond deleted the feat/client-metadata branch July 10, 2023 16:37
@federicobond federicobond requested review from tcarrio and toddbaert and removed request for toddbaert and tcarrio August 31, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants