Skip to content

Commit

Permalink
Fix build failure at llvm-rc on windows due to codepage error on zydis (
Browse files Browse the repository at this point in the history
#3088)

This fix is for the following error when building with llvm on windows

```
[build] llvm-rc: Error in VERSIONINFO statement (ID 1): 
[proc] The command: "C:\Program Files\CMake\bin\cmake.exe" --build C:/.../git/jak-project-test/out/build/Release --parallel 8 exited with code: 1
[build] Non-ASCII 8-bit codepoint (´┐¢) can't be interpreted in the current codepage
[build] ninja: build stopped: subcommand failed.
```

It's caused by llvm-rc not handling non 8-bit characters.
The same issue is discussed in the curl project here
curl/curl#7765

This commit copies the fix from curl, replacing '©' with '(C)'.
  • Loading branch information
jabermony authored Oct 15, 2023
1 parent e6b73f1 commit 95dca76
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion third-party/zydis/resources/VersionInfo.rc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 95dca76

Please sign in to comment.