Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrong statement about security groups #610

Merged

Conversation

marco-hoyer
Copy link
Contributor

Security groups are bound to a specific VPC and thus to an AWS region but not to a single AZ or DC. I would like to remove this statement to prevent confusions.

Security groups are bound to a specific VPC and thus to an AWS region but not to a single AZ or DC.
@DavidTPate
Copy link
Contributor

Yeah that sentence definitely doesn't make much sense.

I think the overall point is correct it is just using the incorrect terms. I'd rather see it reworded to something like this:

Security groups are not shared across VPCs or Accounts, so if you are utilizing infrastructure in multiple VPCs or Accounts you should make sure your configuration/deployment tools take that into account.

From my look through the VPC/Network section I don't see a mention of the above.

@tiagoasousa
Copy link

please be mindfull that security groups for vpc peering across accounts exist.
https://aws.amazon.com/about-aws/whats-new/2016/03/announcing-support-for-security-group-references-in-a-peered-vpc/

@marco-hoyer
Copy link
Contributor Author

@networkpadawan you're right but I would argue it is a bit different. Security groups are still bound to one VPC/Account/Region but they can be referenced in another VPC/Account/Region when VPC peering is applied.

@marco-hoyer
Copy link
Contributor Author

@DavidTPate like your approach. I extended it a bit. Better?

Copy link
Contributor

@DavidTPate DavidTPate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing the comments.

@QuinnyPig
Copy link
Collaborator

Thanks for the hard work!

@QuinnyPig QuinnyPig merged commit 0c2f370 into open-guides:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants