From 391943842169daa9ea8e94a861d3eeb70f02fe37 Mon Sep 17 00:00:00 2001 From: ulixius9 Date: Wed, 24 Jan 2024 15:36:13 +0530 Subject: [PATCH] Fix #14590: Improve airflow plugin error message --- .../service/clients/pipeline/airflow/AirflowRESTClient.java | 6 ++++-- .../common/AirflowMessageBanner/AirflowMessageBanner.tsx | 5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/clients/pipeline/airflow/AirflowRESTClient.java b/openmetadata-service/src/main/java/org/openmetadata/service/clients/pipeline/airflow/AirflowRESTClient.java index 81472e836a9a..94f0e9d5ccdc 100644 --- a/openmetadata-service/src/main/java/org/openmetadata/service/clients/pipeline/airflow/AirflowRESTClient.java +++ b/openmetadata-service/src/main/java/org/openmetadata/service/clients/pipeline/airflow/AirflowRESTClient.java @@ -292,7 +292,7 @@ public PipelineServiceClientResponse getServiceStatusInternal() { // APIs URL not found if (response.statusCode() == 404) { return buildUnhealthyStatus( - "Airflow APIs not found. Please follow the installation guide."); + "Airflow APIs not found. Please validate if the OpenMetadata Airflow plugin is installed correctly. Follow [this guide](https://docs.open-metadata.org/v1.2.x/deployment/ingestion/openmetadata) for further details."); } return buildUnhealthyStatus( @@ -306,7 +306,9 @@ public PipelineServiceClientResponse getServiceStatusInternal() { } catch (InterruptedException e) { Thread.currentThread().interrupt(); return buildUnhealthyStatus( - String.format("Failed to get REST status due to [%s].", e.getMessage())); + String.format( + "Failed to get REST status due to [%s] - Please validate if Airflow is up and running.", + e.getMessage())); } } diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/AirflowMessageBanner/AirflowMessageBanner.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/AirflowMessageBanner/AirflowMessageBanner.tsx index f2f9c36d960d..2d5e76427c1b 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/AirflowMessageBanner/AirflowMessageBanner.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/AirflowMessageBanner/AirflowMessageBanner.tsx @@ -10,12 +10,13 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { Space, SpaceProps, Typography } from 'antd'; +import { Space, SpaceProps } from 'antd'; import classNames from 'classnames'; import { isEmpty } from 'lodash'; import React, { FC } from 'react'; import { ReactComponent as IconRetry } from '../../../assets/svg/ic-retry-icon.svg'; import { useAirflowStatus } from '../../../hooks/useAirflowStatus'; +import RichTextEditorPreviewer from '../../common/RichTextEditor/RichTextEditorPreviewer'; import './airflow-message-banner.less'; const AirflowMessageBanner: FC = ({ className }) => { @@ -32,7 +33,7 @@ const AirflowMessageBanner: FC = ({ className }) => { data-testid="no-airflow-placeholder" size={16}> - {reason} + ); };