Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12908 support for table owner in postgres #14289

Merged
merged 9 commits into from
Dec 20, 2023
Merged

#12908 support for table owner in postgres #14289

merged 9 commits into from
Dec 20, 2023

Conversation

NiharDoshi99
Copy link
Contributor

Describe your changes:

Fixes

I worked on
#12908

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@NiharDoshi99 NiharDoshi99 requested a review from a team as a code owner December 7, 2023 06:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

OnkarVO7
OnkarVO7 suggested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@OnkarVO7 OnkarVO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NiharDoshi99 left a few comments and can you please add some exception handling to the same

ingestion/src/metadata/ingestion/source/database/postgres/metadata.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/database/postgres/metadata.py Outdated Show resolved Hide resolved
...a-spec/src/main/resources/json/schema/metadataIngestion/databaseServiceMetadataPipeline.json Outdated Show resolved Hide resolved
@ulixius9 ulixius9 added the safe to test Add this label to run secure Github workflows on PRs label Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@ulixius9 ulixius9 mentioned this pull request Dec 7, 2023
Closed
9 tasks
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
31.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@OnkarVO7 OnkarVO7 merged commit 4920927 into open-metadata:main Dec 20, 2023
30 checks passed
@pmbrull pmbrull mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnkarVO7 OnkarVO7 OnkarVO7 approved these changes

Assignees
No one assigned
Labels
backend documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NiharDoshi99 @OnkarVO7 @ulixius9