Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13445 Profiler Graph Should not Show a Point if value is None #14345

Merged
merged 3 commits into from
Dec 12, 2023
Merged

#13445 Profiler Graph Should not Show a Point if value is None #14345

merged 3 commits into from
Dec 12, 2023

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Dec 12, 2023 •
edited
Loading

Describe your changes:

Fixes #13445

  • refactored the logic to generate profiler metrics
  • updated logic to not show points in the graph if data is not available.
  • added unit test for changes
Screen.Recording.2023-12-12.at.11.13.11.AM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Dec 12, 2023
@ShaileshParmar11 ShaileshParmar11 self-assigned this Dec 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 49.44% (24633/49826) 32.14% (9626/29949) 30.67% (2787/9088)

Sachin-chaurasiya
Sachin-chaurasiya reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, thanks

...data-ui/src/main/resources/ui/src/components/TableProfiler/Component/SingleColumnProfile.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/utils/TableProfilerUtils.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) December 12, 2023 14:29
@ShaileshParmar11 ShaileshParmar11 merged commit 2337e23 into main Dec 12, 2023
14 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the issue-13445 branch December 12, 2023 14:50
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@ShaileshParmar11
open-metadata#13445 Profiler Graph Should not Show a Point if value i…
1d7338d 
…s None (open-metadata#14345)

* open-metadata#13445 Profiler Graph Should not Show a Point if value is None

* addressing comment

* fixed sonarcloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiler Graph Should not Show a Point if value is None
3 participants
@ShaileshParmar11 @chirag-madlani @Sachin-chaurasiya