From 2bae858343841a96ec9ea2134ee5cb34d868d936 Mon Sep 17 00:00:00 2001
From: Ashish Gupta <ashish@getcollate.io>
Date: Thu, 8 Feb 2024 11:14:12 +0530
Subject: [PATCH 1/3] fix sso logo breaking due to antd icons component

---
 .../src/main/antlr4/org/openmetadata/schema/EntityLink.g4    | 1 +
 .../resources/ui/src/components/LoginButton/LoginButton.tsx  | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/openmetadata-spec/src/main/antlr4/org/openmetadata/schema/EntityLink.g4 b/openmetadata-spec/src/main/antlr4/org/openmetadata/schema/EntityLink.g4
index 5dafdd495893..c79665116bac 100644
--- a/openmetadata-spec/src/main/antlr4/org/openmetadata/schema/EntityLink.g4
+++ b/openmetadata-spec/src/main/antlr4/org/openmetadata/schema/EntityLink.g4
@@ -120,6 +120,7 @@ ENTITY_FIELD
     | 'testCaseResult'
     | 'tests'
     | 'pipelineStatus'
+    | 'dataProducts'
     ;
 
     
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx b/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx
index e1f592d5d01f..13022cc6df70 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx
@@ -19,7 +19,7 @@ import './login-button.style.less';
 
 interface LoginButtonProps {
   ssoBrandName: string;
-  ssoBrandLogo?: SvgComponent;
+  ssoBrandLogo?: string;
   onClick?: () => void;
 }
 
@@ -32,8 +32,7 @@ const LoginButton = ({
     <Icon
       alt={`${ssoBrandName} Logo`}
       className="align-middle"
-      component={ssoBrandLogo}
-      style={{ fontSize: '30px' }}
+      component={() => <img height="30px" src={ssoBrandLogo} width="30px" />}
     />
   ) : null;
 

From 8292ffc455110221ed0f85c36f4080034b8d510b Mon Sep 17 00:00:00 2001
From: Ashish Gupta <ashish@getcollate.io>
Date: Thu, 8 Feb 2024 12:22:25 +0530
Subject: [PATCH 2/3] fix sonar issue

---
 .../ui/src/components/LoginButton/LoginButton.tsx   | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx b/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx
index 13022cc6df70..5a8b2b4cde9a 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx
@@ -28,17 +28,26 @@ const LoginButton = ({
   ssoBrandLogo,
   onClick,
 }: LoginButtonProps) => {
+  const getImageElement = () => (
+    <img
+      alt={`${ssoBrandName} Logo`}
+      height="30px"
+      src={ssoBrandLogo}
+      width="30px"
+    />
+  );
+
   const svgIcon = ssoBrandLogo ? (
     <Icon
       alt={`${ssoBrandName} Logo`}
       className="align-middle"
-      component={() => <img height="30px" src={ssoBrandLogo} width="30px" />}
+      component={getImageElement}
     />
   ) : null;
 
   return (
     <Button className="signin-button m-x-auto" icon={svgIcon} onClick={onClick}>
-      <span className="font-medium text-grey-muted text-xl">
+      <span className="font-medium text-grey-muted text-xl m-l-0">
         {t('label.sign-in-with-sso', { sso: ssoBrandName })}
       </span>
     </Button>

From 16741a46f236f326489e78412d5508d1e778949f Mon Sep 17 00:00:00 2001
From: Ashish Gupta <ashish@getcollate.io>
Date: Thu, 8 Feb 2024 14:55:46 +0530
Subject: [PATCH 3/3] fix deploy ingestion icon

---
 .../main/resources/ui/src/assets/svg/creating-ingestion.svg   | 2 +-
 .../src/main/resources/ui/src/assets/svg/deploy-ingestion.svg | 2 +-
 .../DeployIngestionLoaderModal/DeployIngestionLoaderModal.tsx | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/creating-ingestion.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/creating-ingestion.svg
index 7b03a5271eba..2b8da57457e6 100644
--- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/creating-ingestion.svg
+++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/creating-ingestion.svg
@@ -1 +1 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" fill="none"><path fill="#fff" d="M27.314 4.686A15.895 15.895 0 0 0 16 0 15.895 15.895 0 0 0 4.686 4.686 15.895 15.895 0 0 0 0 16c0 4.274 1.664 8.292 4.686 11.314.224.224.534.31.824.26h.001l7.575-1.326a.938.938 0 0 0 .501-.26L25.77 13.804a.937.937 0 0 0 0-1.326l-6.25-6.25a.937.937 0 0 0-1.325 0L6.012 18.413a.937.937 0 0 0-.26.501l-.989 5.648A14.017 14.017 0 0 1 1.875 16C1.875 8.211 8.211 1.875 16 1.875S30.125 8.211 30.125 16 23.789 30.125 16 30.125A.938.938 0 0 0 16 32c4.274 0 8.292-1.664 11.314-4.686A15.895 15.895 0 0 0 32 16c0-4.274-1.664-8.292-4.686-11.314ZM7.288 21.013l3.698 3.699-4.483.785.785-4.484Zm5.636 2.985L11.126 22.2l10.856-10.857 1.799 1.799-10.857 10.856Zm5.933-15.78 1.8 1.8L9.8 20.874 8 19.075 18.858 8.218Z"/></svg>
\ No newline at end of file
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32" fill="none"><path fill="#fff" d="M27.314 4.686A15.895 15.895 0 0 0 16 0 15.895 15.895 0 0 0 4.686 4.686 15.895 15.895 0 0 0 0 16c0 4.274 1.664 8.292 4.686 11.314.224.224.534.31.824.26h.001l7.575-1.326a.938.938 0 0 0 .501-.26L25.77 13.804a.937.937 0 0 0 0-1.326l-6.25-6.25a.937.937 0 0 0-1.325 0L6.012 18.413a.937.937 0 0 0-.26.501l-.989 5.648A14.017 14.017 0 0 1 1.875 16C1.875 8.211 8.211 1.875 16 1.875S30.125 8.211 30.125 16 23.789 30.125 16 30.125A.938.938 0 0 0 16 32c4.274 0 8.292-1.664 11.314-4.686A15.895 15.895 0 0 0 32 16c0-4.274-1.664-8.292-4.686-11.314ZM7.288 21.013l3.698 3.699-4.483.785.785-4.484Zm5.636 2.985L11.126 22.2l10.856-10.857 1.799 1.799-10.857 10.856Zm5.933-15.78 1.8 1.8L9.8 20.874 8 19.075 18.858 8.218Z"/></svg>
\ No newline at end of file
diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/deploy-ingestion.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/deploy-ingestion.svg
index a2b4c38ba139..56f329c0ae5c 100644
--- a/openmetadata-ui/src/main/resources/ui/src/assets/svg/deploy-ingestion.svg
+++ b/openmetadata-ui/src/main/resources/ui/src/assets/svg/deploy-ingestion.svg
@@ -1 +1 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" fill="none"><path fill="#fff" d="M30.646.053.71 9.834c-.846.276-.968 1.426-.199 1.874l11.313 6.578c.357.207.803.182 1.134-.064l3.18-2.362-2.361 3.18a1.032 1.032 0 0 0-.064 1.135l6.578 11.313c.448.77 1.598.646 1.874-.199l9.782-29.935A1.033 1.033 0 0 0 30.646.053Zm-9.727 28.405-5.078-8.733 6.123-8.245a1.032 1.032 0 0 0-1.444-1.444l-8.245 6.123-8.733-5.078 25.811-8.434-8.434 25.811Zm-10.081-5.836-6.854 6.854a1.032 1.032 0 0 1-1.46-1.46l6.854-6.854a1.032 1.032 0 0 1 1.46 1.46Zm-9.055.26a1.032 1.032 0 0 1 0-1.46l2.705-2.705a1.032 1.032 0 0 1 1.46 1.46L3.243 22.88a1.032 1.032 0 0 1-1.46 0Zm11.5 3.17a1.032 1.032 0 0 1 0 1.46l-2.704 2.704a1.029 1.029 0 0 1-.73.303c-.912 0-1.382-1.11-.73-1.762l2.704-2.705a1.032 1.032 0 0 1 1.46 0Z"/></svg>
\ No newline at end of file
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32" fill="none"><path fill="#fff" d="M30.646.053.71 9.834c-.846.276-.968 1.426-.199 1.874l11.313 6.578c.357.207.803.182 1.134-.064l3.18-2.362-2.361 3.18a1.032 1.032 0 0 0-.064 1.135l6.578 11.313c.448.77 1.598.646 1.874-.199l9.782-29.935A1.033 1.033 0 0 0 30.646.053Zm-9.727 28.405-5.078-8.733 6.123-8.245a1.032 1.032 0 0 0-1.444-1.444l-8.245 6.123-8.733-5.078 25.811-8.434-8.434 25.811Zm-10.081-5.836-6.854 6.854a1.032 1.032 0 0 1-1.46-1.46l6.854-6.854a1.032 1.032 0 0 1 1.46 1.46Zm-9.055.26a1.032 1.032 0 0 1 0-1.46l2.705-2.705a1.032 1.032 0 0 1 1.46 1.46L3.243 22.88a1.032 1.032 0 0 1-1.46 0Zm11.5 3.17a1.032 1.032 0 0 1 0 1.46l-2.704 2.704a1.029 1.029 0 0 1-.73.303c-.912 0-1.382-1.11-.73-1.762l2.704-2.705a1.032 1.032 0 0 1 1.46 0Z"/></svg>
\ No newline at end of file
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Modals/DeployIngestionLoaderModal/DeployIngestionLoaderModal.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Modals/DeployIngestionLoaderModal/DeployIngestionLoaderModal.tsx
index 31f0ab810b21..8d93ed64dadc 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/Modals/DeployIngestionLoaderModal/DeployIngestionLoaderModal.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/Modals/DeployIngestionLoaderModal/DeployIngestionLoaderModal.tsx
@@ -64,7 +64,7 @@ const DeployIngestionLoaderModal = ({
                   <Icon
                     className="align-middle"
                     component={IconCreateIngestion}
-                    style={{ fontSize: '16px' }}
+                    style={{ fontSize: '26px' }}
                   />
                 </Typography.Text>
               </Typography.Text>
@@ -79,7 +79,7 @@ const DeployIngestionLoaderModal = ({
                   <Icon
                     className="align-middle"
                     component={IconDeployIngestion}
-                    style={{ fontSize: '16px' }}
+                    style={{ fontSize: '26px' }}
                   />
                 </Typography.Text>
               </Typography.Text>