Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15112: Fix metabase lineage via api #15165

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Fix #15112: Fix metabase lineage via api #15165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a60e867
Fix #15112: Fix metabase lineage via api
ulixius9 Feb 13, 2024
88c6b25
fix pytests
ulixius9 Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ingestion/src/metadata/ingestion/source/dashboard/metabase/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,9 @@ def _yield_lineage_from_api(
self, chart_details: MetabaseChart, db_service_name: str, dashboard_name: str
) -> Iterable[Either[AddLineageRequest]]:
table = self.client.get_table(chart_details.table_id)
table_name = table.name or table.display_name

if table is None or table.display_name is None:
if table is None or table_name is None:
return

database_name = table.db.details.db if table.db and table.db.details else None
Expand All @@ -334,7 +335,7 @@ def _yield_lineage_from_api(
database=database_name,
service_name=db_service_name,
database_schema=table.table_schema,
table=table.display_name,
table=table_name,
)

to_fqn = fqn.build(
Expand Down
Loading