From 5364d731b3ec5c455bf5c89fcebad0f2ffa15a6c Mon Sep 17 00:00:00 2001
From: Harsh Vador <harsh.vador@somaiya.edu>
Date: Tue, 20 Feb 2024 12:44:34 +0530
Subject: [PATCH 1/2] test: unit test case of notification box

---
 .../NotificationBox.component.tsx             |   3 +-
 .../NotificationBox/NotificationBox.test.tsx  | 166 ++++++++++++++++++
 2 files changed, 167 insertions(+), 2 deletions(-)
 create mode 100644 openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.test.tsx

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.component.tsx
index 731f4679bdc7..043ed358c658 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.component.tsx
@@ -50,7 +50,6 @@ const NotificationBox = ({
   const { currentUser } = useAuthContext();
   const [notifications, setNotifications] = useState<Thread[]>([]);
   const [isLoading, setIsLoading] = useState<boolean>(false);
-
   const [viewAllPath, setViewAllPath] = useState<string>(
     getUserPath(
       currentUser?.name as string,
@@ -191,7 +190,7 @@ const NotificationBox = ({
   );
 
   return (
-    <div className="notification-box">
+    <div className="notification-box" data-testid="notification-box">
       <Typography.Title
         className="p-x-md p-t-sm p-b-xss"
         data-testid="notification-heading"
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.test.tsx
new file mode 100644
index 000000000000..b8ce91ff9cf8
--- /dev/null
+++ b/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.test.tsx
@@ -0,0 +1,166 @@
+/*
+ *  Copyright 2024 Collate.
+ *  Licensed under the Apache License, Version 2.0 (the "License");
+ *  you may not use this file except in compliance with the License.
+ *  You may obtain a copy of the License at
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+import { act, fireEvent, render, screen } from '@testing-library/react';
+import React from 'react';
+import { NOTIFICATION_READ_TIMER } from '../../constants/constants';
+import { FeedFilter } from '../../enums/mydata.enum';
+import { ThreadType } from '../../generated/api/feed/createThread';
+import { getFeedsWithFilter } from '../../rest/feedsAPI';
+import NotificationBox from './NotificationBox.component';
+
+const mockThread = [
+  {
+    userId: '011bdb24-90a7-4a97-ba66-24002adb2b12',
+    filterType: FeedFilter.ASSIGNED_TO,
+    id: '33873393-bd68-46e9-bccc-7701c1c41ad6',
+    type: ThreadType.Task,
+    threadTs: 1703570590556,
+    about: 'test',
+    entityId: '6206a003-281c-4984-9728-4e949a4e4023',
+    posts: [
+      {
+        id: '12345',
+        message: 'Resolved the Task.',
+        postTs: 1703570590652,
+        from: 'admin',
+        reactions: [],
+      },
+    ],
+    task: {
+      id: 6,
+      type: 'RequestTestCaseFailureResolution',
+      assignees: [
+        {
+          id: '011bdb24-90a7-4a97-ba66-24002adb2b12',
+          type: 'user',
+          name: 'aaron_johnson0',
+          fullyQualifiedName: 'aaron_johnson0',
+          displayName: 'Aaron Johnson',
+          deleted: false,
+        },
+      ],
+      status: 'Closed',
+      closedBy: 'admin',
+      closedAt: 1703570590648,
+      newValue: 'Resolution comment',
+      testCaseResolutionStatusId: 'f93d08e9-2d38-4d01-a294-f8b44fbb0f4a',
+    },
+  },
+];
+const tabList = ['Tasks', 'Mentions'];
+const mockShowErrorToast = jest.fn();
+const mockOnMarkTaskNotificationRead = jest.fn();
+const mockUserData = {
+  name: 'aaron_johnson0',
+  email: 'testUser1@email.com',
+  id: '011bdb24-90a7-4a97-ba66-24002adb2b12',
+  isAdmin: true,
+};
+
+const mockProps = {
+  hasMentionNotification: true,
+  hasTaskNotification: true,
+  onMarkMentionsNotificationRead: jest.fn(),
+  onMarkTaskNotificationRead: mockOnMarkTaskNotificationRead,
+  onTabChange: jest.fn(),
+};
+
+jest.mock('../../rest/feedsAPI', () => ({
+  getFeedsWithFilter: jest
+    .fn()
+    .mockImplementation(() => Promise.resolve({ data: mockThread })),
+  getFilters: jest.fn().mockImplementation(() => ({
+    threadType: ThreadType.Task,
+    feedFilter: FeedFilter.ASSIGNED_TO,
+  })),
+}));
+
+jest.mock('../../utils/FeedUtils', () => ({
+  getEntityFQN: jest.fn().mockReturnValue('entityFQN'),
+  getEntityType: jest.fn().mockReturnValue('entityType'),
+}));
+
+jest.mock('./NotificationFeedCard.component', () => {
+  return jest.fn().mockReturnValue(<p>NotificationFeedCard</p>);
+});
+
+jest.mock('../Auth/AuthProviders/AuthProvider', () => ({
+  useAuthContext: jest.fn(() => ({
+    currentUser: mockUserData,
+  })),
+}));
+
+jest.mock('../../utils/ToastUtils', () => ({
+  showErrorToast: jest.fn().mockImplementation(() => mockShowErrorToast()),
+}));
+
+describe('Test NotificationBox Component', () => {
+  it('should render NotificationBox', async () => {
+    await act(async () => {
+      render(<NotificationBox {...mockProps} />);
+    });
+    const notificationBox = await screen.findByTestId('notification-box');
+    const notificationHeading = await screen.findByTestId(
+      'notification-heading'
+    );
+
+    expect(notificationBox).toBeInTheDocument();
+    expect(notificationHeading).toHaveTextContent('label.notification-plural');
+  });
+
+  it('should render tabs', async () => {
+    await act(async () => {
+      render(<NotificationBox {...mockProps} />);
+    });
+    const tabs = await screen.findAllByRole('tab');
+
+    expect(tabs).toHaveLength(tabList.length);
+  });
+
+  it('should render error toast if any error occurs', async () => {
+    (getFeedsWithFilter as jest.Mock).mockRejectedValue(new Error());
+    await act(async () => {
+      render(<NotificationBox {...mockProps} />);
+    });
+
+    expect(mockShowErrorToast).toHaveBeenCalled();
+  });
+
+  it('should call onMarkTaskNotificationRead when active tab is changed', async () => {
+    jest.useFakeTimers();
+
+    await act(async () => {
+      render(<NotificationBox {...mockProps} />);
+    });
+    const tabs = await screen.findAllByRole('tab');
+    await act(async () => {
+      fireEvent.click(tabs[0]);
+    });
+    jest.advanceTimersByTime(NOTIFICATION_READ_TIMER);
+
+    expect(mockOnMarkTaskNotificationRead).toHaveBeenCalled();
+  });
+
+  it('should render no data in case of no notification', async () => {
+    (getFeedsWithFilter as jest.Mock).mockImplementation(() =>
+      Promise.resolve({ data: [] })
+    ),
+      await act(async () => {
+        render(<NotificationBox {...mockProps} />);
+      });
+
+    expect(
+      await screen.findByText('message.no-notification-found')
+    ).toBeInTheDocument();
+  });
+});

From 6b5acac468a652c073245284373b01fd9d945f0b Mon Sep 17 00:00:00 2001
From: Harsh Vador <harsh.vador@somaiya.edu>
Date: Tue, 20 Feb 2024 13:17:59 +0530
Subject: [PATCH 2/2] remove unnecessary assertion

---
 .../components/NotificationBox/NotificationBox.component.tsx    | 2 +-
 .../ui/src/components/NotificationBox/NotificationBox.test.tsx  | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.component.tsx
index 043ed358c658..76dae732cdb8 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.component.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.component.tsx
@@ -190,7 +190,7 @@ const NotificationBox = ({
   );
 
   return (
-    <div className="notification-box" data-testid="notification-box">
+    <div className="notification-box">
       <Typography.Title
         className="p-x-md p-t-sm p-b-xss"
         data-testid="notification-heading"
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.test.tsx b/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.test.tsx
index b8ce91ff9cf8..510c8eba9f47 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.test.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/NotificationBox/NotificationBox.test.tsx
@@ -109,12 +109,10 @@ describe('Test NotificationBox Component', () => {
     await act(async () => {
       render(<NotificationBox {...mockProps} />);
     });
-    const notificationBox = await screen.findByTestId('notification-box');
     const notificationHeading = await screen.findByTestId(
       'notification-heading'
     );
 
-    expect(notificationBox).toBeInTheDocument();
     expect(notificationHeading).toHaveTextContent('label.notification-plural');
   });