From dd34ecfda3fee99afd30e245e0d078eee6fc35d9 Mon Sep 17 00:00:00 2001 From: Gilles Gouaillardet Date: Wed, 19 Jun 2024 15:47:45 +0900 Subject: [PATCH] opal: fix opal_basename() for single character filenames Thanks Jeff Hammond for the bug report Refs. open-mpi/ompi#12619 Signed-off-by: Gilles Gouaillardet --- opal/util/basename.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/opal/util/basename.c b/opal/util/basename.c index 0a57b070788..f5121156498 100644 --- a/opal/util/basename.c +++ b/opal/util/basename.c @@ -10,8 +10,8 @@ * Copyright (c) 2004-2005 The Regents of the University of California. * All rights reserved. * Copyright (c) 2009-2014 Cisco Systems, Inc. All rights reserved. - * Copyright (c) 2014-2015 Research Organization for Information Science - * and Technology (RIST). All rights reserved. + * Copyright (c) 2014-2024 Research Organization for Information Science + * and Technology (RIST). All rights reserved. * Copyright (c) 2014 Intel, Inc. All rights reserved. * $COPYRIGHT$ * @@ -77,16 +77,18 @@ char *opal_basename(const char *filename) /* Remove trailing sep's (note that we already know that strlen > 0) */ tmp = strdup(filename); - for (i = strlen(tmp) - 1; i > 0; --i) { - if (sep == tmp[i]) { - tmp[i] = '\0'; - } else { - break; + if (1 < strlen(tmp)) { + for (i = strlen(tmp) - 1; i > 0; --i) { + if (sep == tmp[i]) { + tmp[i] = '\0'; + } else { + break; + } + } + if (0 == i) { + tmp[0] = sep; + return tmp; } - } - if (0 == i) { - tmp[0] = sep; - return tmp; } /* Look for the final sep */