Skip to content

Revert "Fix a race condition between registering a callback and completing a request" #11499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsquyres merged 1 commit into from
Mar 21, 2023
Merged

Revert "Fix a race condition between registering a callback and completing a request" #11499

jsquyres merged 1 commit into from
Mar 21, 2023

Conversation

@devreal
Copy link
Contributor

@devreal devreal commented Mar 17, 2023

This reverts commit b6467d0 from #11460. The change breaks some persistent op implementations, which do not reinitialize the request object. @bosilca and I will bring this back with a consistent fix.

Fixes #11493

@devreal
Revert "Fix a race condition between registering a callback and compl…
236e180 
…eting a request"

This reverts commit b6467d0. The change
breaks some persistent op implementations, which do not reinitialize the
request object.
@devreal devreal requested a review from bosilca March 17, 2023 20:07
@jsquyres
Copy link
Member

jsquyres commented Mar 18, 2023

bot:ibm:retest

@dalcinl
Copy link
Contributor

dalcinl commented Mar 21, 2023

@jsquyres Can you please retest to move this one forward?

@bosilca
Copy link
Member

bosilca commented Mar 21, 2023

bot:ibm:builds:retest

@artemry-nv artemry-nv mentioned this pull request Mar 21, 2023
Merged
@jsquyres
Copy link
Member

jsquyres commented Mar 21, 2023

IBM's CI has been broken since this weekend. I know they're still investigating.

Let's talk about this PR on the webex today -- I think it might be worthwhile to merge it anyway, even before IBM's CI comes back, because we know that that PR's reverting of a prior commit (that, ironically, was merged even though there were CI failures) will enable Mellanox CI to pass.

@jjhursey
Copy link
Member

jjhursey commented Mar 21, 2023

bot:ibm:retest

@jsquyres
Copy link
Member

jsquyres commented Mar 21, 2023

Let's talk about this PR on the webex today -- I think it might be worthwhile to merge it anyway, even before IBM's CI comes back, because we know that that PR's reverting of a prior commit (that, ironically, was merged even though there were CI failures) will enable Mellanox CI to pass.

Scratch that. IBM CI is back up and running 🎉 -- CI for this PR is queued up and will run shortly.

@jjhursey
Copy link
Member

jjhursey commented Mar 21, 2023

bot:ibm:retest

@jsquyres
Copy link
Member

jsquyres commented Mar 21, 2023

bot:ibm:retest

Thanks @jjhursey

@jsquyres jsquyres merged commit 1d07dae into open-mpi:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bosilca bosilca bosilca approved these changes

Assignees

No one assigned

Labels

Target: main

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mpi4py: Regression with partitioned communication

5 participants

@devreal @jsquyres @dalcinl @bosilca @jjhursey