Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with backward docking and added initial in-place rotation #70

Open
wants to merge 4 commits into
base: humble
Choose a base branch
from

Conversation

Jakubach
Copy link

@Jakubach Jakubach commented Nov 8, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses ticket
Primary OS tested on (Ubuntu 22.04)
Robotic platform tested on (Gazebo simulation)
Does this PR contain AI generated software? (No)

Description of contribution in a few bullet points

  • Fixed an issue with backward docking
  • Added a initial rotation functionality
  • Added a minimal angular velocity parameter which is used for initial rotation
  • Updated readme file

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@Jakubach Jakubach changed the title Fixed issue with backward docking and added in place rotation Fixed issue with backward docking and added initial in-place rotation Nov 8, 2024
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See ros-navigation/navigation2#4749 (review)

If it helps, maybe we just do reviews in the navigation2 version so we get it all hammered out there. Then once that is approved, we update this PR. I think that'll make your life easier than repeatedly doing the same thing 2x each review cycle. I could see that getting frustrating :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants