Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plugins to be passed to SDK instance #3826

Closed
edpaget opened this issue Sep 28, 2021 · 0 comments
Closed

Allow plugins to be passed to SDK instance #3826

edpaget opened this issue Sep 28, 2021 · 0 comments

Comments

@edpaget
Copy link
Contributor

edpaget commented Sep 28, 2021

Expected Behavior

I can specify custom plugins for the OPA Go SDK to use.

Actual Behavior

Calling runtime.RegisterPlugin doesn't register them with the SDK and the SDK itself provides no method to add plugins.

Steps to Reproduce the Problem

N/A

Additional Info

@anderseknert suggested posting a request for this feature after I asked on slack.
@edpaget edpaget mentioned this issue Sep 28, 2021
Merged
edpaget added a commit to edpaget/opa that referenced this issue Oct 1, 2021
@edpaget
sdk: Allow map of plugins to be passed to SDK
f6fa2af 
This adds a Plugins field to the SDK Options struct that accepts a
map[string]plugins.Factory similarly to the map created by
runtime.RegisterPlugin this map is passed to the discovery.Factories
plugin similarly, again, to how it works within the Runtime module. This
allows an OPA SDK instance to initialize plugins.

Fixes open-policy-agent#3826

Signed-off-by: Edward Paget <edward.paget@chime.com>

Fixed changes requested by @tsandall (squash before merge)

Signed-off-by: Edward Paget <edward.paget@chime.com>
edpaget added a commit to 1debit/opa that referenced this issue Oct 7, 2021
@edpaget
sdk: Allow map of plugins to be passed to SDK
017a238 
This adds a Plugins field to the SDK Options struct that accepts a
map[string]plugins.Factory similarly to the map created by
runtime.RegisterPlugin this map is passed to the discovery.Factories
plugin similarly, again, to how it works within the Runtime module. This
allows an OPA SDK instance to initialize plugins.

Fixes open-policy-agent#3826

Signed-off-by: Edward Paget <edward.paget@chime.com>

Fixed changes requested by @tsandall (squash before merge)

Signed-off-by: Edward Paget <edward.paget@chime.com>
dolevf pushed a commit to dolevf/opa that referenced this issue Nov 4, 2021
@edpaget @dolevf
sdk: Allow map of plugins to be passed to SDK
ced8b04 
This adds a Plugins field to the SDK Options struct that accepts a
map[string]plugins.Factory similarly to the map created by
runtime.RegisterPlugin this map is passed to the discovery.Factories
plugin similarly, again, to how it works within the Runtime module. This
allows an OPA SDK instance to initialize plugins.

Fixes open-policy-agent#3826

Signed-off-by: Edward Paget <edward.paget@chime.com>

Fixed changes requested by @tsandall (squash before merge)

Signed-off-by: Edward Paget <edward.paget@chime.com>
Signed-off-by: Dolev Farhi <farhi.dolev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edpaget