Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compile to linux-aarch64 from linux-x64 in GitHub actions. #253

Merged
1 commit merged into from
Sep 11, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 11, 2023

This commit adds a new CI job called linux_aarch64.
This new job builds OpenSSL 3.1, liboqs and oqs-provider for linux-aarch64 (elf64-littleaarch64).

@ghost ghost self-assigned this Sep 11, 2023
@ghost ghost mentioned this pull request Sep 11, 2023
4 tasks
@ghost ghost marked this pull request as ready for review September 11, 2023 13:53
@ghost ghost requested a review from baentsch as a code owner September 11, 2023 13:53
Copy link

@jgoertzen-sb jgoertzen-sb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@jgoertzen-sb
Copy link

My mistake @baentsch I thought this was a different project when I reviewed it. Sorry!

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM. One version nit only...

@baentsch
Copy link
Member

My mistake @baentsch I thought this was a different project when I reviewed it. Sorry!

Yeah -- all code looks alike these days given all those ChatGPT bots doing someone's work :-) More seriously: Thanks @thb-sb for doing this!

@ghost ghost force-pushed the aarch64 branch 2 times, most recently from 462c31f to 436f9ad Compare September 11, 2023 14:27
@ghost ghost requested a review from baentsch September 11, 2023 14:28
This commit adds a new CI job called `linux_aarch64`.
This new job builds OpenSSL master, liboqs and oqs-provider for linux-aarch64 (`elf64-littleaarch64`).

Finally, unit tests are run using qemu.
@ghost ghost merged commit 7dc61fe into open-quantum-safe:main Sep 11, 2023
12 checks passed
@ghost ghost deleted the aarch64 branch September 11, 2023 17:15
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
…n-quantum-safe#253)

This commit adds a new CI job called `linux_aarch64`.
This new job builds OpenSSL master, liboqs and oqs-provider for linux-aarch64 (`elf64-littleaarch64`).

Finally, unit tests are run using qemu.

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants