Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support web proxy in external interop tests #288

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

mouse07410
Copy link
Contributor

Update oqsprovider-externalinterop.sh to support web proxy in external interop tests. To determine whether to resort to proxy handling, checks if env var HTTP_PROXY is set

Fixes #282

Update oqsprovider-externalinterop.sh to support web proxy in external interop tests.
To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set
@mouse07410 mouse07410 requested a review from baentsch as a code owner October 19, 2023 01:23
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mouse07410
Copy link
Contributor Author

@baentsch when do you think this one would be merged? I'm eager to delete my fork of this repo.

@baentsch
Copy link
Member

@baentsch when do you think this one would be merged? I'm eager to delete my fork of this repo.

Are you charged for having this fork? I've been trying to understand why CI's failing on this/what's going wrong with the Windows build. Or in other words, I'm not eager merging something with CI failing. But then again, your code has nothing to do with this, so I bite this bullet.

@baentsch baentsch merged commit 39fdbfe into open-quantum-safe:main Oct 19, 2023
14 of 18 checks passed
@mouse07410
Copy link
Contributor Author

Are you charged for having this fork?

He... Not really - but I already have more repos up here than is comfortable, so I'm trying to keep their number down.

I've been trying to understand why CI's failing on this/what's going wrong with the Windows build.

That would be interesting to know - but as you pointed out:

your code has nothing to do with this

Exactly. I'm willing to bet that other CI on this repo also fail on Windows.

Of course, I've no idea whether OpenSSL app (executable) on Windows accepts the same parameters (-proxy, -allow_proxy_certs), or even what version it is at.

so I bite this bullet

Thanks!

feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 13, 2024
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests.
To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 16, 2024
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests.
To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests.
To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests.
To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this pull request Mar 17, 2024
Update oqsprovider-externalinterop.sh to support web proxy in external interop tests.
To determine whether to resort to proxy handling, checks if env var `HTTP_PROXY` is set

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Cloudflare test "kills" other tests
2 participants