update script with latest zenoh api #149
Conversation
tomkimsour
force-pushed
the
easy-full-control-zenoh-1.0.0.b4
branch
6 times, most recently
from
9fddeac to
dee69c4
Compare
|
I saw that migrating to zenoh 1.0.0 was on your todo list and I needed it so I migrated it. I also was able to run it on humble with rmf_ros2 2.7.1 tag. |
There was a problem hiding this comment.
Thanks for the huge help with the migration! Yes I was definitely planning to get to 1.0.0 soon, but was hesitant with it still being in beta, and free_fleet's lack of static and integration tests (it's WIP though!)
I've just done a first pass and left a few comments, I'll need to run some tests manually too. The merge conflict is most definitely from #146, where some minor tests and testing infra have been added
edit: just curious, have you been testing with hardware? Or with the simulation examples so far?
tomkimsour
force-pushed
the
easy-full-control-zenoh-1.0.0.b4
branch
from
dee69c4 to
0c8311d
Compare
Signed-off-by: thomasung <thomas.ung@pal-robotics.com>
Signed-off-by: thomasung <thomas.ung@pal-robotics.com>
Signed-off-by: thomasung <thomas.ung@pal-robotics.com> clean dangling code
tomkimsour
force-pushed
the
easy-full-control-zenoh-1.0.0.b4
branch
from
0c8311d to
9625a6f
Compare
Signed-off-by: thomasung <thomas.ung@pal-robotics.com>
tomkimsour
force-pushed
the
easy-full-control-zenoh-1.0.0.b4
branch
from
6b3590d to
eb48b1f
Compare
|
NB: I've been testing with zenoh 1.0.0 and the upgrade does not seem to break anything |
|
Outstanding!!!
David
===================================================
Ubiquity Robotics, Inc. is honored to win the Silicon Valley Robotics
good robot industry award in the commercialization category.
Ubiquity Robotics wins SVR good robot industry award
<https://svrobo.org/ubiquity-robotics-wins-commercialization-award-in-svr-good-robot-industry-awards/>
…On Wed, Oct 30, 2024 at 10:55 AM Thomas Ung ***@***.***> wrote:
NB: I've been testing with zenoh 1.0.0 and the upgrade does not seem to
break anything
—
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYN4VQDDHWZ4FWQ6R3YOO3Z6CUH3AVCNFSM6AAAAABP7M3ZOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWGM4DMNBUGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
Thanks for the updates! I've a few last comments, and after linting is fixed, we should be good to merge.
edit: adding the job logs, https://github.com/open-rmf/free_fleet/actions/runs/11368807346/job/32189477205
| @@ -43,7 +43,7 @@ sudo apt install python3-pip ros-jazzy-rmw-cyclonedds-cpp | |||
| The dependencies `eclipse-zenoh` and `pycdr2` are available through `pip`. Users can choose to set up a virtual environment, or `--break-system-packages` by performing the installation directly. | |||
|
|
|||
| ```bash | |||
| pip3 install eclipse-zenoh==0.11.0 pycdr2 --break-system-packages | |||
| pip3 install pip install eclipse-zenoh==1.0.0b4 pycdr2 --break-system-packages | |||
There was a problem hiding this comment.
| pip3 install pip install eclipse-zenoh==1.0.0b4 pycdr2 --break-system-packages | |
| pip install eclipse-zenoh==1.0.0 pycdr2 --break-system-packages |
| @@ -23,7 +23,7 @@ Supports | |||
| * [ROS 2 Jazzy](https://docs.ros.org/en/jazzy/index.html) | |||
| * [rmw-cyclonedds-cpp](https://github.com/ros2/rmw_cyclonedds) | |||
| * [Open-RMF on main](https://github.com/open-rmf/rmf) | |||
| * [zenoh-bridge-ros2dds v0.11](https://github.com/eclipse-zenoh/zenoh-plugin-ros2dds/releases/tag/0.11.0) | |||
| * [zenoh-bridge-ros2dds v1.0.0-beta.4](https://github.com/eclipse-zenoh/zenoh-plugin-ros2dds/releases/tag/1.0.0-beta.4) | |||
There was a problem hiding this comment.
We can update this to v1.0.0 now that it has been released. I just ran the same tests and it's looking good
There was a problem hiding this comment.
yes, sorry I didn't see that comment, I'm using 1.0.0 now and it is indeed working the same way
There was a problem hiding this comment.
should it be reverted and fixed ?
New feature implementation
Implemented feature
Migrate zenoh to zenoh 1.0.0.b4