-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update script with latest zenoh api #149
Merged
aaronchongth
merged 4 commits into
open-rmf:easy-full-control
from
tomkimsour:easy-full-control-zenoh-1.0.0.b4
Nov 7, 2024
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -23,7 +23,7 @@ Supports | |||||
* [ROS 2 Jazzy](https://docs.ros.org/en/jazzy/index.html) | ||||||
* [rmw-cyclonedds-cpp](https://github.com/ros2/rmw_cyclonedds) | ||||||
* [Open-RMF on main](https://github.com/open-rmf/rmf) | ||||||
* [zenoh-bridge-ros2dds v0.11](https://github.com/eclipse-zenoh/zenoh-plugin-ros2dds/releases/tag/0.11.0) | ||||||
* [zenoh-bridge-ros2dds v1.0.0-beta.4](https://github.com/eclipse-zenoh/zenoh-plugin-ros2dds/releases/tag/1.0.0-beta.4) | ||||||
|
||||||
We recommend setting up `zenoh-bridge-ros2dds` with the standalone binaries. After downloading the appropriate released version and platform, extract and use the standalone binaries as is. For source builds of `zenoh-bridge-ros2dds`, please follow the [official guides](https://github.com/eclipse-zenoh/zenoh-plugin-ros2dds). | ||||||
|
||||||
|
@@ -43,7 +43,7 @@ sudo apt install python3-pip ros-jazzy-rmw-cyclonedds-cpp | |||||
The dependencies `eclipse-zenoh` and `pycdr2` are available through `pip`. Users can choose to set up a virtual environment, or `--break-system-packages` by performing the installation directly. | ||||||
|
||||||
```bash | ||||||
pip3 install eclipse-zenoh==0.11.0 pycdr2 --break-system-packages | ||||||
pip3 install pip install eclipse-zenoh==1.0.0b4 pycdr2 --break-system-packages | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
``` | ||||||
|
||||||
> [!NOTE] | ||||||
|
@@ -124,7 +124,7 @@ source ~/ff_ws/install/setup.bash | |||||
ros2 run free_fleet_examples test_navigate_to_pose.py \ | ||||||
--frame-id map \ | ||||||
--namespace turtlebot3_1 \ | ||||||
-x 1.808 | ||||||
-x 1.808 \ | ||||||
-y 0.503 | ||||||
``` | ||||||
|
||||||
|
@@ -256,7 +256,6 @@ ros2 run rmf_demos_tasks dispatch_patrol \ | |||||
* attempt to optimize tf messages (not all are needed) | ||||||
* ROS 1 nav support | ||||||
* map switching support | ||||||
* update to use zenoh 1.0 | ||||||
* static testing | ||||||
* end-to-end testing | ||||||
* support for Rolling | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can update this to
v1.0.0
now that it has been released. I just ran the same tests and it's looking goodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, sorry I didn't see that comment, I'm using 1.0.0 now and it is indeed working the same way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be reverted and fixed ?