From e6bee51658d856031330c4d6922b11e9446fee90 Mon Sep 17 00:00:00 2001 From: Shubham Tiwari Date: Thu, 15 Feb 2024 20:07:20 +0530 Subject: [PATCH 1/5] Feature: Added information about PR with unassigned issue to the contributing guidelines #251 --- docs/contributing/introduction-to-contributing.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/contributing/introduction-to-contributing.md b/docs/contributing/introduction-to-contributing.md index adf4fcb1..0c42cdca 100644 --- a/docs/contributing/introduction-to-contributing.md +++ b/docs/contributing/introduction-to-contributing.md @@ -52,7 +52,7 @@ See [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) for m ## Pull Requests (PR) -**_We actively welcome your pull requests. However, you must link your work to an existing issue._** +**_We actively welcome your pull requests. However, you must ensure that **you are assigned** to an existing issue before working on changes, and you need to **link your work to the issue** in your PR form._** 1. Fork the repo and create your branch from the default branch. 2. Name your branch to something descriptive of your work, i.e., `add-navbar` or `fix/broken-links`. @@ -66,9 +66,13 @@ See [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) for m - The title must begin with "feat:", "fix:", or anything related to your changes.
**Tips**: You can follow your chosen option when [committing](#commits) your changes. - - Unsolicited code is welcomed, but an issue is required to announce your intentions.
**_PRs without a linked issue will be marked invalid and closed_**. - -> [!IMPORTANT] + - Unsolicited code is welcomed, but an issue is required to announce your intentions. + +⚠️ **PRs will be marked as invalid and may be closed if:** + - the issue is not assigned to the contributor who opened the PR + - no issue is linked to the PR + +> **IMPORTANT:** > Please do not DM Maintainers or contact them outside of GitHub if you want a PR Review. If you haven't received a review within a week, please tag them in the PR comments to ask for an estimated time of review. > _**Note for maintainers**: All PRs need a label to assist automation. See [this guide](./triage-guide.md#adding-issue-and-pr-labels) to determine which labels to use._ From 207c0212e50b18ca369d4b1d897802910b388dbd Mon Sep 17 00:00:00 2001 From: Shubham Tiwari Date: Thu, 15 Feb 2024 20:09:45 +0530 Subject: [PATCH 2/5] Feature: Added information about PR with unassigned issue to the contributing guidelines #251 --- docs/contributing/introduction-to-contributing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributing/introduction-to-contributing.md b/docs/contributing/introduction-to-contributing.md index 0c42cdca..72b3a870 100644 --- a/docs/contributing/introduction-to-contributing.md +++ b/docs/contributing/introduction-to-contributing.md @@ -52,7 +52,7 @@ See [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) for m ## Pull Requests (PR) -**_We actively welcome your pull requests. However, you must ensure that **you are assigned** to an existing issue before working on changes, and you need to **link your work to the issue** in your PR form._** +_We actively welcome your pull requests. However, you must ensure that **you are assigned** to an existing issue before working on changes, and you need to **link your work to the issue** in your PR form._ 1. Fork the repo and create your branch from the default branch. 2. Name your branch to something descriptive of your work, i.e., `add-navbar` or `fix/broken-links`. From 58a09dc72844dcd7daef39fa35461c2897bbe919 Mon Sep 17 00:00:00 2001 From: Shubham Tiwari Date: Fri, 16 Feb 2024 01:05:24 +0530 Subject: [PATCH 3/5] fixes : removed horizontal lines and also the underscore(italics) --- docs/contributing/introduction-to-contributing.md | 5 ++++- package.json | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/contributing/introduction-to-contributing.md b/docs/contributing/introduction-to-contributing.md index 72b3a870..686738b3 100644 --- a/docs/contributing/introduction-to-contributing.md +++ b/docs/contributing/introduction-to-contributing.md @@ -51,8 +51,11 @@ After running this command, you can push your changes to the remote repo. See [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) for more examples. ## Pull Requests (PR) +--- + +We actively welcome your pull requests. However, you must ensure that **you are assigned** to an existing issue before working on changes, and you need to **link your work to the issue** in your PR form. -_We actively welcome your pull requests. However, you must ensure that **you are assigned** to an existing issue before working on changes, and you need to **link your work to the issue** in your PR form._ +--- 1. Fork the repo and create your branch from the default branch. 2. Name your branch to something descriptive of your work, i.e., `add-navbar` or `fix/broken-links`. diff --git a/package.json b/package.json index 3d0fb779..65a6bb09 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "version": "1.63.2", "private": true, "engines": { - "node": "^18", + "node": "^20.8.0", "npm": ">=9" }, "scripts": { From 586f3be66d2e3b91fe5a9cb65be8a78eaee44ed3 Mon Sep 17 00:00:00 2001 From: Shubham Tiwari Date: Fri, 16 Feb 2024 14:58:28 +0530 Subject: [PATCH 4/5] changes in package.json / docs/contributing/introduction-to-contributing.md --- docs/contributing/introduction-to-contributing.md | 7 ++++--- package.json | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/contributing/introduction-to-contributing.md b/docs/contributing/introduction-to-contributing.md index 686738b3..972c3d19 100644 --- a/docs/contributing/introduction-to-contributing.md +++ b/docs/contributing/introduction-to-contributing.md @@ -71,9 +71,10 @@ We actively welcome your pull requests. However, you must ensure that **you are - Unsolicited code is welcomed, but an issue is required to announce your intentions. -⚠️ **PRs will be marked as invalid and may be closed if:** - - the issue is not assigned to the contributor who opened the PR - - no issue is linked to the PR +⚠️ **PRs will be marked as invalid and may be closed if:** + +- the issue is not assigned to the contributor who opened the PR +- no issue is linked to the PR > **IMPORTANT:** > Please do not DM Maintainers or contact them outside of GitHub if you want a PR Review. If you haven't received a review within a week, please tag them in the PR comments to ask for an estimated time of review. diff --git a/package.json b/package.json index 65a6bb09..3d0fb779 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "version": "1.63.2", "private": true, "engines": { - "node": "^20.8.0", + "node": "^18", "npm": ">=9" }, "scripts": { From c7dbf63ed9ddd549fed7f03755e4522c34e9fd6f Mon Sep 17 00:00:00 2001 From: Ayu Adiati Date: Fri, 16 Feb 2024 11:52:26 +0100 Subject: [PATCH 5/5] fix: add break line --- docs/contributing/introduction-to-contributing.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributing/introduction-to-contributing.md b/docs/contributing/introduction-to-contributing.md index 972c3d19..fcad062b 100644 --- a/docs/contributing/introduction-to-contributing.md +++ b/docs/contributing/introduction-to-contributing.md @@ -76,7 +76,7 @@ We actively welcome your pull requests. However, you must ensure that **you are - the issue is not assigned to the contributor who opened the PR - no issue is linked to the PR -> **IMPORTANT:** +> **IMPORTANT:**
> Please do not DM Maintainers or contact them outside of GitHub if you want a PR Review. If you haven't received a review within a week, please tag them in the PR comments to ask for an estimated time of review. > _**Note for maintainers**: All PRs need a label to assist automation. See [this guide](./triage-guide.md#adding-issue-and-pr-labels) to determine which labels to use._