Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on Python 3.6 and Python 2.7 #1587

Merged
merged 5 commits into from
Oct 20, 2017
Merged

Rely on Python 3.6 and Python 2.7 #1587

merged 5 commits into from
Oct 20, 2017

Conversation

martinholmer
Copy link
Collaborator

This pull request simplifies the Tax-Calculator check-in testing and conda-package releasing processes by relying only on Python 2.7 and Python 3.6, which are the only two versions of Python available on the Anaconda download page. There have been only a few (mostly linux) downloads of Python 3.5 taxcalc packages out of a total of 4,367 downloads, and Python 3.6 is fairly mature now. There seems to be no need to build the five taxcalc packages for Python 3.5.

@codecov-io
Copy link

codecov-io commented Oct 12, 2017

Codecov Report

Merging #1587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1587   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        2743    2743           
======================================
  Hits         2743    2743

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20aee9b...c11bbab. Read the comment docs.

@martinholmer
Copy link
Collaborator Author

martinholmer commented Oct 12, 2017

The need to eliminate the exact pinning of the conda package in the appveyor.yml file in pull request #1587 is yet another example of the evils of exact pinning discussed in PolicyBrain issue 697.

The exact pinning of the conda package to version 4.2.13 created a package inconsistency with conda==4.2.13 requiring old versions of packages that are no longer supported by Python 3.6.
This inconsistency was eliminated by the use of at-least pinning conda>=4.3.0. Notice that the current version of conda is 4.3.29.

@martinholmer martinholmer merged commit 9db2477 into PSLmodels:master Oct 20, 2017
@martinholmer martinholmer deleted the python-35 branch October 20, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants