Use sampling seed to standardize records subsample in test_pufcsv.py #869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request eliminates randomness in the sub sample selected in the sampling test added in pull request #844 (as fixed in #864). It also does two other things. First, it moves the comparison of combined tax liabilities generated by the sub-sample and the full-sample into the test_agg() function in order to reduce test execution time. Second, it uses a sampling random-number seed that produces a relatively small difference under current-law policy between the sub-sample and full-sample combined tax liability. Below is the maximum (among the ten years of results from 2013 to 2022) relative difference between the sub-sample combined tax liability and the full-sample combined tax liability for each of nine tested sampling random-number seeds:
These results show that picking the "right" sampling seed will make a big difference in user satisfaction.
@MattHJensen @feenberg @talumbau @Amy-Xu @GoFroggyRun @zrisher @codykallen