-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search metrics #366
Draft
sarhiri
wants to merge
2,769
commits into
open-source-labs:dev
Choose a base branch
from
oslabs-beta:search-metrics
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Search metrics #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inventory simplified
implementing createItem functionality
Orders 2:19PM
services hooked - chronos configured but not working
added service name when connected to each PORT
added chronosconfig
add dotenv and chronos config to event-bus
The system information coming from si was strangley not being passed to through the function. The function was being called syncronously and because all the si function are async the return at the end of the function was always passing an empty array. This is because although the data from si was coming in, it was being pushed into an empty array defined at the top of the file inside of a .then and becuase the return was executing synchrounously the array was never being updated. Added awaits to each of the si functions and now the data is moving again
refactoring the mongo.health function The data from health metrics was not being passed out and there is now an error with duplicate mongo entries
Stephenfeature
The filter on the health data array now checks for null values. This resulted in an error since we were inputting multiple nulls into the same db.
Prior to this change new metrics were added based on the an arbitrary length variable that was changed after the awaiting a find call to the mongo db. Current metrics is now queried directly. Two layers of awaits are still necessary when calling the find on the metrics db due to the queueing of all the await calls by the different services. Am looking in to making it more streamm line
Moved the metrics model find function inside the health metrics function so that the data from the metrics model is populated before the length check between the current metrics and the health metrics
…ibed comments from prior groups
Current metrics is only needed within this function to compare the lengths between current metrics and health metrics. Instead of grabbging current metrics outside of the function it is now grabbing the current metrics data before the length check.
Upon load of the graphscontainer component an event call is made to electron (health request) which calls the mongo fetch function which grabs all the health data stored inside of the individual services databases. Inside of the mongoFetch function there is a call for the grafana api key database. In the microservices portion of the app grafana is not used so there is no key. This was causing an error and preventing data flow. This portion is being commented out temporarily so that more specific controls can be made to differentiate between apps that use docker (and thus grafana) and microservices
Stephenfeature
Chronos npm
Ted modular
MUI Splash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Purpose
Approach
Learning
Screenshot(s)