From 1a5e38bd65bc280f93b90baf4a71134b01e80987 Mon Sep 17 00:00:00 2001 From: Jakub Skiba <40868522+bsponge@users.noreply.github.com> Date: Mon, 22 Apr 2024 16:51:46 +0200 Subject: [PATCH] [receiver/hostmetrics] Fix failing tests (#32583) Fixing failing tests - recover `scraperFactories` var value after `TestGatherMetrics_ScraperKeyConfigError` and `TestGatherMetrics_CreateMetricsScraperError` tests Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32536 --- receiver/hostmetricsreceiver/hostmetrics_receiver_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/receiver/hostmetricsreceiver/hostmetrics_receiver_test.go b/receiver/hostmetricsreceiver/hostmetrics_receiver_test.go index 4523923fa6ef..0fc98476bc09 100644 --- a/receiver/hostmetricsreceiver/hostmetrics_receiver_test.go +++ b/receiver/hostmetricsreceiver/hostmetrics_receiver_test.go @@ -239,7 +239,11 @@ func (m *mockScraper) Scrape(context.Context) (pmetric.Metrics, error) { } func TestGatherMetrics_ScraperKeyConfigError(t *testing.T) { + tmp := scraperFactories scraperFactories = map[string]internal.ScraperFactory{} + defer func() { + scraperFactories = tmp + }() sink := new(consumertest.MetricsSink) cfg := &Config{Scrapers: map[string]internal.Config{"error": &mockConfig{}}} @@ -250,7 +254,11 @@ func TestGatherMetrics_ScraperKeyConfigError(t *testing.T) { func TestGatherMetrics_CreateMetricsScraperError(t *testing.T) { mFactory := &mockFactory{} mFactory.On("CreateMetricsScraper").Return(&mockScraper{}, errors.New("err1")) + tmp := scraperFactories scraperFactories = map[string]internal.ScraperFactory{mockTypeStr: mFactory} + defer func() { + scraperFactories = tmp + }() sink := new(consumertest.MetricsSink) cfg := &Config{Scrapers: map[string]internal.Config{mockTypeStr: &mockConfig{}}}