[receiver/cloudfoundryreceiver] Move shardID check to validate in the…

… config

Co-authored-by: Jose Riguera <jose.riguera@springer.com>
Co-authored-by: Sam Clulow <sam.clulow@springernature.com>

receiver/cloudfoundryreceiver/config.go

@@ -7,6 +7,7 @@ import (
  "errors"
  "fmt"
  "net/url"
+ "strings"
 
  "go.opentelemetry.io/collector/config/confighttp"
  "go.opentelemetry.io/collector/config/configopaque"
@@ -47,6 +48,10 @@ func (c *Config) Validate() error {
  return err
  }
 
+ if strings.TrimSpace(c.RLPGateway.ShardID) == "" {
+ return errors.New("shardID cannot be empty")
+ }
+
  err = validateURLOption("uaa.endpoint", c.UAA.Endpoint)
  if err != nil {
  return err

receiver/cloudfoundryreceiver/stream.go

@@ -8,7 +8,6 @@ import (
  "errors"
  "fmt"
  "net/http"
- "strings"
 
  "code.cloudfoundry.org/go-loggregator"
  "code.cloudfoundry.org/go-loggregator/rpc/loggregator_v2"
@@ -49,10 +48,6 @@ func (rgc *EnvelopeStreamFactory) CreateStream(
  ctx context.Context,
  shardID string) (loggregator.EnvelopeStream, error) {
 
- if strings.TrimSpace(shardID) == "" {
- return nil, errors.New("shardID cannot be empty")
- }
-
  stream := rgc.rlpGatewayClient.Stream(ctx, &loggregator_v2.EgressBatchRequest{
  ShardId: shardID,
  Selectors: []*loggregator_v2.Selector{