diff --git a/.golangci.yml b/.golangci.yml index 27206273d148b..53d3ba663adee 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -89,6 +89,9 @@ linters-settings: - name: context-keys-type # Importing with `.` makes the programs much harder to understand - name: dot-imports + - name: early-return + arguments: + - "preserveScope" # Empty blocks make code less readable and could be a symptom of a bug or unfinished refactoring. - name: empty-block # for better readability, variables of type `error` must be named with the prefix `err`. @@ -111,6 +114,8 @@ linters-settings: - name: redefines-builtin-id # redundant else-blocks that can be eliminated from the code. - name: superfluous-else + arguments: + - "preserveScope" # prevent confusing name for variables when using `time` package - name: time-naming # warns when an exported function or method returns a value of an un-exported type. diff --git a/internal/aws/metrics/metric_calculator.go b/internal/aws/metrics/metric_calculator.go index 16435ef7f7540..979bb91a6c50e 100644 --- a/internal/aws/metrics/metric_calculator.go +++ b/internal/aws/metrics/metric_calculator.go @@ -26,11 +26,10 @@ func NewFloat64DeltaCalculator() MetricCalculator { func calculateDelta(prev *MetricValue, val any, _ time.Time) (any, bool) { var deltaValue float64 - if prev != nil { - deltaValue = val.(float64) - prev.RawValue.(float64) - } else { + if prev == nil { return deltaValue, false } + deltaValue = val.(float64) - prev.RawValue.(float64) return deltaValue, true } diff --git a/internal/sqlquery/scraper.go b/internal/sqlquery/scraper.go index 680a6164fa0af..0de61c0559e9e 100644 --- a/internal/sqlquery/scraper.go +++ b/internal/sqlquery/scraper.go @@ -74,11 +74,10 @@ func (s *Scraper) ScrapeMetrics(ctx context.Context) (pmetric.Metrics, error) { out := pmetric.NewMetrics() rows, err := s.Client.QueryRows(ctx) if err != nil { - if errors.Is(err, ErrNullValueWarning) { - s.Logger.Warn("problems encountered getting metric rows", zap.Error(err)) - } else { + if !errors.Is(err, ErrNullValueWarning) { return out, fmt.Errorf("Scraper: %w", err) } + s.Logger.Warn("problems encountered getting metric rows", zap.Error(err)) } ts := pcommon.NewTimestampFromTime(time.Now()) rms := out.ResourceMetrics()