diff --git a/.chloggen/rename_remoteobserverprocessor.yaml b/.chloggen/rename_remoteobserverprocessor.yaml new file mode 100644 index 000000000000..9b5f66c3e10c --- /dev/null +++ b/.chloggen/rename_remoteobserverprocessor.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: breaking + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: remoteobserverprocessor + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Rename remoteobserverprocessor to remotetapprocessor + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [27873] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [user, api] diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 1d27470e335e..73d7e273cbec 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -164,7 +164,7 @@ processor/metricsgenerationprocessor/ @open-te processor/metricstransformprocessor/ @open-telemetry/collector-contrib-approvers @dmitryax processor/probabilisticsamplerprocessor/ @open-telemetry/collector-contrib-approvers @jpkrohling processor/redactionprocessor/ @open-telemetry/collector-contrib-approvers @leonsp-ai @dmitryax @mx-psi @TylerHelmuth -processor/remoteobserverprocessor/ @open-telemetry/collector-contrib-approvers @pmcollins +processor/remotetapprocessor/ @open-telemetry/collector-contrib-approvers @pmcollins processor/resourcedetectionprocessor/ @open-telemetry/collector-contrib-approvers @Aneurysm9 @dashpole processor/resourcedetectionprocessor/internal/azure/ @open-telemetry/collector-contrib-approvers @mx-psi processor/resourcedetectionprocessor/internal/heroku/ @open-telemetry/collector-contrib-approvers @atoulme diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml index d1d91220666a..c6f25e7e5752 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yaml +++ b/.github/ISSUE_TEMPLATE/bug_report.yaml @@ -153,7 +153,7 @@ body: - processor/metricstransform - processor/probabilisticsampler - processor/redaction - - processor/remoteobserver + - processor/remotetap - processor/resource - processor/resourcedetection - processor/resourcedetection/internal/azure diff --git a/.github/ISSUE_TEMPLATE/feature_request.yaml b/.github/ISSUE_TEMPLATE/feature_request.yaml index 10256f615027..f9f313cbe6bd 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yaml +++ b/.github/ISSUE_TEMPLATE/feature_request.yaml @@ -147,7 +147,7 @@ body: - processor/metricstransform - processor/probabilisticsampler - processor/redaction - - processor/remoteobserver + - processor/remotetap - processor/resource - processor/resourcedetection - processor/resourcedetection/internal/azure diff --git a/.github/ISSUE_TEMPLATE/other.yaml b/.github/ISSUE_TEMPLATE/other.yaml index 9a033cb3b277..22e51b758e9c 100644 --- a/.github/ISSUE_TEMPLATE/other.yaml +++ b/.github/ISSUE_TEMPLATE/other.yaml @@ -147,7 +147,7 @@ body: - processor/metricstransform - processor/probabilisticsampler - processor/redaction - - processor/remoteobserver + - processor/remotetap - processor/resource - processor/resourcedetection - processor/resourcedetection/internal/azure diff --git a/.github/dependabot.yml b/.github/dependabot.yml index e297110c4f41..5ab201b72859 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -588,7 +588,7 @@ updates: interval: "weekly" day: "wednesday" - package-ecosystem: "gomod" - directory: "/processor/remoteobserverprocessor" + directory: "/processor/remotetapprocessor" schedule: interval: "weekly" day: "wednesday" diff --git a/cmd/otelcontribcol/builder-config.yaml b/cmd/otelcontribcol/builder-config.yaml index f01625479043..39ff9f138c25 100644 --- a/cmd/otelcontribcol/builder-config.yaml +++ b/cmd/otelcontribcol/builder-config.yaml @@ -102,7 +102,7 @@ processors: - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanprocessor v0.88.0 - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor v0.88.0 - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/transformprocessor v0.88.0 - - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor v0.88.0 + - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor v0.88.0 receivers: - gomod: go.opentelemetry.io/collector/receiver/otlpreceiver v0.88.1-0.20231026220224-6405e152a2d9 @@ -405,7 +405,7 @@ replaces: - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowseventlogreceiver => ../../receiver/windowseventlogreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/webhookeventreceiver => ../../receiver/webhookeventreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecsobserver => ../../extension/observer/ecsobserver - - github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor => ../../processor/remoteobserverprocessor + - github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor => ../../processor/remotetapprocessor - github.com/open-telemetry/opentelemetry-collector-contrib/processor/sumologicprocessor => ../../processor/sumologicprocessor # see https://github.com/mattn/go-ieproxy/issues/45 - github.com/mattn/go-ieproxy => github.com/mattn/go-ieproxy v0.0.1 diff --git a/cmd/otelcontribcol/components.go b/cmd/otelcontribcol/components.go index e5e358e21c56..ff3858e0180e 100644 --- a/cmd/otelcontribcol/components.go +++ b/cmd/otelcontribcol/components.go @@ -99,7 +99,7 @@ import ( metricstransformprocessor "github.com/open-telemetry/opentelemetry-collector-contrib/processor/metricstransformprocessor" probabilisticsamplerprocessor "github.com/open-telemetry/opentelemetry-collector-contrib/processor/probabilisticsamplerprocessor" redactionprocessor "github.com/open-telemetry/opentelemetry-collector-contrib/processor/redactionprocessor" - remoteobserverprocessor "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor" + remotetapprocessor "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor" resourcedetectionprocessor "github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor" resourceprocessor "github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor" routingprocessor "github.com/open-telemetry/opentelemetry-collector-contrib/processor/routingprocessor" @@ -397,7 +397,7 @@ func components() (otelcol.Factories, error) { spanprocessor.NewFactory(), tailsamplingprocessor.NewFactory(), transformprocessor.NewFactory(), - remoteobserverprocessor.NewFactory(), + remotetapprocessor.NewFactory(), ) if err != nil { return otelcol.Factories{}, err diff --git a/cmd/otelcontribcol/go.mod b/cmd/otelcontribcol/go.mod index e88ad93641b8..d4b74c1202e2 100644 --- a/cmd/otelcontribcol/go.mod +++ b/cmd/otelcontribcol/go.mod @@ -86,7 +86,7 @@ require ( github.com/open-telemetry/opentelemetry-collector-contrib/processor/metricstransformprocessor v0.88.0 github.com/open-telemetry/opentelemetry-collector-contrib/processor/probabilisticsamplerprocessor v0.88.0 github.com/open-telemetry/opentelemetry-collector-contrib/processor/redactionprocessor v0.88.0 - github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor v0.88.0 + github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor v0.88.0 github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.88.0 github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor v0.88.0 github.com/open-telemetry/opentelemetry-collector-contrib/processor/routingprocessor v0.88.0 @@ -1113,7 +1113,7 @@ replace github.com/open-telemetry/opentelemetry-collector-contrib/receiver/webho replace github.com/open-telemetry/opentelemetry-collector-contrib/extension/observer/ecsobserver => ../../extension/observer/ecsobserver -replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor => ../../processor/remoteobserverprocessor +replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor => ../../processor/remotetapprocessor replace github.com/open-telemetry/opentelemetry-collector-contrib/processor/sumologicprocessor => ../../processor/sumologicprocessor diff --git a/cmd/otelcontribcol/processors_test.go b/cmd/otelcontribcol/processors_test.go index 5e6e433c395a..053d8290d3ae 100644 --- a/cmd/otelcontribcol/processors_test.go +++ b/cmd/otelcontribcol/processors_test.go @@ -24,7 +24,7 @@ import ( "github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/attraction" "github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/testdata" "github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor" - "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor" + "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor" "github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourceprocessor" "github.com/open-telemetry/opentelemetry-collector-contrib/processor/spanprocessor" ) @@ -139,9 +139,9 @@ func TestDefaultProcessors(t *testing.T) { processor: "redaction", }, { - processor: "remoteobserver", + processor: "remotetap", getConfigFn: func() component.Config { - cfg := procFactories["remoteobserver"].CreateDefaultConfig().(*remoteobserverprocessor.Config) + cfg := procFactories["remotetap"].CreateDefaultConfig().(*remotetapprocessor.Config) cfg.Endpoint = "localhost:0" return cfg }, diff --git a/processor/remoteobserverprocessor/Makefile b/processor/remotetapprocessor/Makefile similarity index 100% rename from processor/remoteobserverprocessor/Makefile rename to processor/remotetapprocessor/Makefile diff --git a/processor/remoteobserverprocessor/README.md b/processor/remotetapprocessor/README.md similarity index 73% rename from processor/remoteobserverprocessor/README.md rename to processor/remotetapprocessor/README.md index ea922c2d2ef4..79277e0f09af 100644 --- a/processor/remoteobserverprocessor/README.md +++ b/processor/remotetapprocessor/README.md @@ -4,7 +4,7 @@ | ------------- |-----------| | Stability | [alpha]: logs, metrics, traces | | Distributions | [contrib] | -| Issues | [![Open issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aopen%20label%3Aprocessor%2Fremoteobserver%20&label=open&color=orange&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aopen+is%3Aissue+label%3Aprocessor%2Fremoteobserver) [![Closed issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aclosed%20label%3Aprocessor%2Fremoteobserver%20&label=closed&color=blue&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aclosed+is%3Aissue+label%3Aprocessor%2Fremoteobserver) | +| Issues | [![Open issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aopen%20label%3Aprocessor%2Fremotetap%20&label=open&color=orange&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aopen+is%3Aissue+label%3Aprocessor%2Fremotetap) [![Closed issues](https://img.shields.io/github/issues-search/open-telemetry/opentelemetry-collector-contrib?query=is%3Aissue%20is%3Aclosed%20label%3Aprocessor%2Fremotetap%20&label=closed&color=blue&logo=opentelemetry)](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aclosed+is%3Aissue+label%3Aprocessor%2Fremotetap) | | [Code Owners](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner) | [@pmcollins](https://www.github.com/pmcollins) | [alpha]: https://github.com/open-telemetry/opentelemetry-collector#alpha diff --git a/processor/remoteobserverprocessor/channelset.go b/processor/remotetapprocessor/channelset.go similarity index 89% rename from processor/remoteobserverprocessor/channelset.go rename to processor/remotetapprocessor/channelset.go index 1574989f8c1f..4314514ae3fb 100644 --- a/processor/remoteobserverprocessor/channelset.go +++ b/processor/remotetapprocessor/channelset.go @@ -1,7 +1,7 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 -package remoteobserverprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor" +package remotetapprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor" import "sync" diff --git a/processor/remoteobserverprocessor/channelset_test.go b/processor/remotetapprocessor/channelset_test.go similarity index 93% rename from processor/remoteobserverprocessor/channelset_test.go rename to processor/remotetapprocessor/channelset_test.go index c186946b4fee..ca05a418e881 100644 --- a/processor/remoteobserverprocessor/channelset_test.go +++ b/processor/remotetapprocessor/channelset_test.go @@ -1,7 +1,7 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 -package remoteobserverprocessor +package remotetapprocessor import ( "testing" diff --git a/processor/remoteobserverprocessor/config.go b/processor/remotetapprocessor/config.go similarity index 84% rename from processor/remoteobserverprocessor/config.go rename to processor/remotetapprocessor/config.go index f202f90200dd..c404111b0b82 100644 --- a/processor/remoteobserverprocessor/config.go +++ b/processor/remotetapprocessor/config.go @@ -1,7 +1,7 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 -package remoteobserverprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor" +package remotetapprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor" import ( "go.opentelemetry.io/collector/component" diff --git a/processor/remoteobserverprocessor/config_test.go b/processor/remotetapprocessor/config_test.go similarity index 90% rename from processor/remoteobserverprocessor/config_test.go rename to processor/remotetapprocessor/config_test.go index bb9ce81ab655..7fdbaf9053ed 100644 --- a/processor/remoteobserverprocessor/config_test.go +++ b/processor/remotetapprocessor/config_test.go @@ -1,7 +1,7 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 -package remoteobserverprocessor +package remotetapprocessor import ( "testing" diff --git a/processor/remoteobserverprocessor/doc.go b/processor/remotetapprocessor/doc.go similarity index 55% rename from processor/remoteobserverprocessor/doc.go rename to processor/remotetapprocessor/doc.go index c7aae9424e8d..fe5b4dfac51c 100644 --- a/processor/remoteobserverprocessor/doc.go +++ b/processor/remotetapprocessor/doc.go @@ -3,7 +3,7 @@ //go:generate mdatagen metadata.yaml -// Package remoteobserverprocessor can be positioned anywhere in a pipeline, allowing +// Package remotetapprocessor can be positioned anywhere in a pipeline, allowing // data to pass through to the next component. Simultaneously, it makes a portion // of the data accessible to WebSocket clients connecting on a configurable port. -package remoteobserverprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor" +package remotetapprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor" diff --git a/processor/remoteobserverprocessor/factory.go b/processor/remotetapprocessor/factory.go similarity index 93% rename from processor/remoteobserverprocessor/factory.go rename to processor/remotetapprocessor/factory.go index 41f0c67a82d3..9391d57dfe67 100644 --- a/processor/remoteobserverprocessor/factory.go +++ b/processor/remotetapprocessor/factory.go @@ -1,7 +1,7 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 -package remoteobserverprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor" +package remotetapprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor" import ( "context" @@ -12,7 +12,7 @@ import ( "go.opentelemetry.io/collector/processor/processorhelper" "github.com/open-telemetry/opentelemetry-collector-contrib/internal/sharedcomponent" - "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor/internal/metadata" + "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor/internal/metadata" ) var processors = sharedcomponent.NewSharedComponents() diff --git a/processor/remoteobserverprocessor/factory_test.go b/processor/remotetapprocessor/factory_test.go similarity index 75% rename from processor/remoteobserverprocessor/factory_test.go rename to processor/remotetapprocessor/factory_test.go index 72c8396f8d35..628a0c34e7cd 100644 --- a/processor/remoteobserverprocessor/factory_test.go +++ b/processor/remotetapprocessor/factory_test.go @@ -1,7 +1,7 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 -package remoteobserverprocessor +package remotetapprocessor import ( "testing" @@ -11,7 +11,7 @@ import ( func TestNewFactory(t *testing.T) { factory := NewFactory() - assert.EqualValues(t, "remoteobserver", factory.Type()) + assert.EqualValues(t, "remotetap", factory.Type()) config := factory.CreateDefaultConfig() assert.NotNil(t, config) } diff --git a/processor/remoteobserverprocessor/go.mod b/processor/remotetapprocessor/go.mod similarity index 99% rename from processor/remoteobserverprocessor/go.mod rename to processor/remotetapprocessor/go.mod index 58a6eac9598a..4ca483199713 100644 --- a/processor/remoteobserverprocessor/go.mod +++ b/processor/remotetapprocessor/go.mod @@ -1,4 +1,4 @@ -module github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor +module github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor go 1.20 diff --git a/processor/remoteobserverprocessor/go.sum b/processor/remotetapprocessor/go.sum similarity index 100% rename from processor/remoteobserverprocessor/go.sum rename to processor/remotetapprocessor/go.sum diff --git a/processor/remoteobserverprocessor/internal/metadata/generated_status.go b/processor/remotetapprocessor/internal/metadata/generated_status.go similarity index 88% rename from processor/remoteobserverprocessor/internal/metadata/generated_status.go rename to processor/remotetapprocessor/internal/metadata/generated_status.go index 9bb1f18c61dc..f3b5f933c20c 100644 --- a/processor/remoteobserverprocessor/internal/metadata/generated_status.go +++ b/processor/remotetapprocessor/internal/metadata/generated_status.go @@ -7,7 +7,7 @@ import ( ) const ( - Type = "remoteobserver" + Type = "remotetap" LogsStability = component.StabilityLevelAlpha MetricsStability = component.StabilityLevelAlpha TracesStability = component.StabilityLevelAlpha diff --git a/processor/remoteobserverprocessor/metadata.yaml b/processor/remotetapprocessor/metadata.yaml similarity index 86% rename from processor/remoteobserverprocessor/metadata.yaml rename to processor/remotetapprocessor/metadata.yaml index a0d756231e4f..76f1f1d17303 100644 --- a/processor/remoteobserverprocessor/metadata.yaml +++ b/processor/remotetapprocessor/metadata.yaml @@ -1,4 +1,4 @@ -type: remoteobserver +type: remotetap status: class: processor diff --git a/processor/remoteobserverprocessor/processor.go b/processor/remotetapprocessor/processor.go similarity index 95% rename from processor/remoteobserverprocessor/processor.go rename to processor/remotetapprocessor/processor.go index e565bd5bd6e0..e9408fb34ea7 100644 --- a/processor/remoteobserverprocessor/processor.go +++ b/processor/remotetapprocessor/processor.go @@ -1,7 +1,7 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 -package remoteobserverprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor" +package remotetapprocessor // import "github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor" import ( "context" diff --git a/processor/remoteobserverprocessor/server_test.go b/processor/remotetapprocessor/server_test.go similarity index 99% rename from processor/remoteobserverprocessor/server_test.go rename to processor/remotetapprocessor/server_test.go index db02683ad948..d74e12e8ea19 100644 --- a/processor/remoteobserverprocessor/server_test.go +++ b/processor/remotetapprocessor/server_test.go @@ -1,7 +1,7 @@ // Copyright The OpenTelemetry Authors // SPDX-License-Identifier: Apache-2.0 -package remoteobserverprocessor +package remotetapprocessor import ( "context" diff --git a/versions.yaml b/versions.yaml index c919bd6a1686..1725df881d52 100644 --- a/versions.yaml +++ b/versions.yaml @@ -156,7 +156,7 @@ module-sets: - github.com/open-telemetry/opentelemetry-collector-contrib/processor/sumologicprocessor - github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor - github.com/open-telemetry/opentelemetry-collector-contrib/processor/transformprocessor - - github.com/open-telemetry/opentelemetry-collector-contrib/processor/remoteobserverprocessor + - github.com/open-telemetry/opentelemetry-collector-contrib/processor/remotetapprocessor - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/activedirectorydsreceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/aerospikereceiver - github.com/open-telemetry/opentelemetry-collector-contrib/receiver/apachereceiver