-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datadog panic's and OTEL collector crashes for empty ExponentialHistogram #26103
Datadog panic's and OTEL collector crashes for empty ExponentialHistogram #26103
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Thanks for the report @lenin-jaganathan, assigning to me to fix this by dropping empty points. |
I am not sure how it generally works in DataDog (also what OpenTelemetry suggests). Do we need to drop the 0 valued datapoints or ingest them as "0"'s? |
For Datadog distributions coming from DogStatsD, dropping would be the closest behavior (IIUC the client library just doesn't produce a point in this case). In the case of OpenTelemetry, I don't think there is a prescription as to what to do here, this is supported for OTLP Histograms (and based on the wording of the spec I would guess also OTLP Exponential Histograms) but the spec generally does not give guidance as to how to map its types other than for well-known systems such as Prometheus.
I believe at present we have no choice but to drop the point. The Datadog distributions payload our intake accepts has an 'average' field, which would have an indeterminate value for this kind of empty points (since it would be |
On, Full agreement here.
I would hope so since this is a consumer-side concern. I brought it up because I have seen some back-end using different aggregation windows and some have problems with non-continuous data streams. But, If data dog can handle that no real concern here. |
I don't think these would be an issue in Datadog's case, but I am open to feedback if you find any issues when trying out the fixed version |
DataDog/opentelemetry-mapping-go/pull/158 fixes this, my intention is for this to be available on |
@mx-psi Did this not make the cut for 0.84? |
Sorry, v0.85.0 🤦, it was already too late for v0.84.0 when I wrote this message |
**Description:** Bumps `github.com/DataDog/opentelemetry-mapping-go` to v0.8.0, fixes crash with empty exponential histograms. **Link to tracking Issue:** Fixes #26103
After merging #26355 I can confirm the fix will be available on v0.85.0. Apologies for the confusion on my previous message. |
Component(s)
exporter/datadog
What happened?
Description
When an empty exponential Histogram is sent with empty buckets, the datadog exporter panic's and crashes the OTEL Collector (using the latest collector-contirb v0.83.0).
Steps to Reproduce
Export a metric datapoint with the below information,
Expected Result
Datapoint with value 0 to be sent to the back-end or Datapoint to be dropped gracefully
Actual Result
Collector version
0.83.0
Environment information
Environment
OS: MacOs/Ubuntu
OpenTelemetry Collector configuration
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: