-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New component: cgroup aware go runtime extension #30289
Comments
cc @open-telemetry/helm-maintainers would love to know what you think (is this something we would want on the Helm chart? If so, anything specific about the design we should take into account?) |
Seems reasonable to me. In the helm chart an extension like this would allow us to remove some templates like https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/templates/_helpers.tpl#L169. A solution like this also helps users running the collector outside of kubernetes. I'd like to see some example configs of how the extension would be configured. |
maybe something like:
|
Would |
I assume that the linux and go relevant interfaces should be stable for long, so I guess no. There may be additional sections. |
Setting gomaxprocs as env var does not reduce core usage as expected . |
It would be interesting to have this extension. Recently, Prometheus added automatic memory limit handling based on the same mechanism. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
I wont be able to work on this issue. @mx-psi do you have someone to assign? |
@tomershafir no, but I can remove the |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
The purpose and use-cases of the new component
Set go runtime variables based on linux cgroupfs automatically, or let the user set a cgroup relative value. For example, set GOMAXPROCS and GOMEMLIMIT by importing https://github.com/uber-go/automaxprocs and https://github.com/KimMachineGun/automemlimit.
Example configuration for the component
Proxy config for https://github.com/uber-go/automaxprocs and https://github.com/KimMachineGun/automemlimit
Telemetry data types supported
It is data type independent
Is this a vendor-specific component?
Code Owner(s)
No response
Sponsor (optional)
@mx-psi
Additional context
I think about a single extension that should theoretically cover the entire go runtime, starting with the 2 variables mentioned above.
Core issue ref: open-telemetry/opentelemetry-collector#9203
The text was updated successfully, but these errors were encountered: