Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kafka] Move Authentication configuration struct from internal to pkg/ #30377

Closed
vincentfree opened this issue Jan 9, 2024 · 5 comments

Comments

@vincentfree
Copy link
Contributor

Component(s)

receiver/kafka

Is your feature request related to a problem? Please describe.

Authentication configuration item is internal making it unusable within other applications.

When using config structs in other projects, it's not great if one out of the 13 fields of the struct is placed in an internal folder. This limits the use of all .go files in that folder to be unusable for other projects to use.

In this case I am trying to use kafkareceiver.Config it has 13 fields of which one uses a struct in the
I have also commented on the following conversation between @dmitryax and the original creator of the move to the internal folder @sakulali.
Both agreed that moving to the pkg/ folder might be a better move but didn't do it so far since no one faced an issue with it so far.

#27289 (comment)

Describe the solution you'd like

Move the code to pkg/, this isn't invasive but makes it possible to actually use the structs used by the exported kafkareceiver.Config and other structs that use this on other receivers/exporters etc.

Describe alternatives you've considered

Move to an other folder but the pkg/ folder seems closest to the standards used in go projects

Additional context

image
@vincentfree vincentfree added enhancement New feature or request needs triage New item requiring triage labels Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax
Copy link
Member

dmitryax commented Jan 9, 2024

@vincentfree, thanks for reporting the issue. All the fields in config structs must be available outside. do you have a chance to submit a PR?

@vincentfree
Copy link
Contributor Author

Hi @dmitryax, I already started :)
I hope I can submit a PR by tomorrow.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants