-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/kafka] Move Authentication configuration struct from internal to pkg/ #30377
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@vincentfree, thanks for reporting the issue. All the fields in config structs must be available outside. do you have a chance to submit a PR? |
Hi @dmitryax, I already started :) |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
receiver/kafka
Is your feature request related to a problem? Please describe.
Authentication configuration item is internal making it unusable within other applications.
When using config structs in other projects, it's not great if one out of the 13 fields of the struct is placed in an internal folder. This limits the use of all
.go
files in that folder to be unusable for other projects to use.In this case I am trying to use
kafkareceiver.Config
it has 13 fields of which one uses a struct in theI have also commented on the following conversation between @dmitryax and the original creator of the move to the internal folder @sakulali.
Both agreed that moving to the
pkg/
folder might be a better move but didn't do it so far since no one faced an issue with it so far.#27289 (comment)
Describe the solution you'd like
Move the code to
pkg/
, this isn't invasive but makes it possible to actually use the structs used by the exportedkafkareceiver.Config
and other structs that use this on other receivers/exporters etc.Describe alternatives you've considered
Move to an other folder but the pkg/ folder seems closest to the standards used in go projects
Additional context
The text was updated successfully, but these errors were encountered: