-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New component: RabbitMQ (message) Receiver #34242
Comments
Yesterday I got a poc up and running. It uses the existing retry logic of the rabbitmqexporter. To avoid hard to maintain copy pasta we may want to move this logic into e.g. Config receivers:
rabbitmqdata:
encoding_extension: otlp_encoding/rabbitmq
connection:
vhost: "/"
endpoint: amqp://localhost:5672
auth:
plain:
username: user
password: password
queue:
- name: otlp_metrics
consumer: col1
exclusive: true
exporters:
debug:
extensions:
otlp_encoding/rabbitmq:
protocol: otlp_json
service:
extensions: [otlp_encoding/rabbitmq]
pipelines:
metrics:
receivers: [rabbitmqdata]
exporters: [debug] Output |
Kind of a mouthful but |
…#34361) This PR moves the retry logic from amqp publisher to amqp connection. Connection, client and other utility structures have been moved from `exporter/rabbitmqexporter/internal/publisher` to `internal/rabbitmq`. **Link to tracking Issue:** #34242 ---- cc @swar8080 @atoulme --------- Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
…open-telemetry#34361) This PR moves the retry logic from amqp publisher to amqp connection. Connection, client and other utility structures have been moved from `exporter/rabbitmqexporter/internal/publisher` to `internal/rabbitmq`. **Link to tracking Issue:** open-telemetry#34242 ---- cc @swar8080 @atoulme --------- Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Good point about the naming, we need to help users distinguish collecting messages from RabbitMQ queues from collecting metrics about RabbitMQ itself. Another option: rename the current RabbitMQ receiver to RabbitMQ Metrics receiver I agree that a RabbitMQ (messages) receiver makes total sense, especially that Contrib already has the exporter. Unfortunately I'm not able to sponsor this component formally as I'm worried I wouldn't have the capacity for code ownership that comes with sponsoring. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
The purpose and use-cases of the new component
Since version v0.104.0 the opentelemetry collector includes a RabbitMQ exporter. While a rabbitmq receiver exists, it is only used to retrieve node metadata.
With the enhanced ability to read from the queue with an OpenTelemetry Collector, it can be used to reroute, manipulate, or further process traffic. #28891 (comment)
Example configuration for the component
Minimal receiver options required to ensure feature parity with exporter
Telemetry data types supported
Logs, metrics, and traces
Is this a vendor-specific component?
Code Owner(s)
@frzifus
Sponsor (optional)
No response
Additional context
Since an exporter and receiver already exist, does it make sense to add the desired functionality to the receiver?
Perhaps someone has an alternative name suggestion which is better then
RabbitMQDataReceiver
? 😅cc @atoulme @swar8080 @djaglowski @cpheps
The text was updated successfully, but these errors were encountered: