Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Data stream routing does not sanitize values #34285

Closed
carsonip opened this issue Jul 29, 2024 · 2 comments · Fixed by #35494
Closed

[exporter/elasticsearch] Data stream routing does not sanitize values #34285

carsonip opened this issue Jul 29, 2024 · 2 comments · Fixed by #35494
Labels
bug Something isn't working exporter/elasticsearch

Comments

@carsonip
Copy link
Contributor

carsonip commented Jul 29, 2024

Component(s)

exporter/elasticsearch

What happened?

Description

Data stream attributes are not sanitized, resulting in non-compliant data stream names. Sanitization should be implemented according to https://www.elastic.co/guide/en/ecs/current/ecs-data_stream.html. There is also an implementation of DS fields sanitization in ES, but in this implementation there is in incorrect handling of an edge case where string limit should be 100 unicode characters instead of 100 bytes.

Steps to Reproduce

Supply a value with - in resource attributes data_stream.dataset or data_stream.namespace

Expected Result

The value is sanitized so that the resulting data stream does not contain -

Actual Result

The resulting data stream contains -.

Collector version

v0.105.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@carsonip carsonip added bug Something isn't working needs triage New item requiring triage labels Jul 29, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jul 29, 2024
@crobert-1
Copy link
Member

Removing needs triage as this was filed by a code owner and makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/elasticsearch
Projects
None yet
2 participants