Skip to content

[extension/cgroupruntime] Add extension to contrib distribution #37201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rogercoll opened this issue Jan 14, 2025 · 6 comments
Closed

[extension/cgroupruntime] Add extension to contrib distribution #37201

rogercoll opened this issue Jan 14, 2025 · 6 comments

Comments

@rogercoll
Copy link
Contributor

Component(s)

extension/cgroupruntime

Is your feature request related to a problem? Please describe.

Dependencies blocked relese: open-telemetry/opentelemetry-collector-releases#792 (comment)

Describe the solution you'd like

Fix dependencies + add to md/otelcontribcol/builder-config.yaml

Describe alternatives you've considered

No response

Additional context

No response

@rogercoll rogercoll added enhancement New feature or request needs triage New item requiring triage labels Jan 14, 2025
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@rogercoll
Copy link
Contributor Author

Trying to compile (make otelcontribcol) the contrib distribution with the cgroupruntime extension produces the following error:

2025-01-14T16:50:15.838+0100    INFO    internal/command.go:97  OpenTelemetry Collector Builder {"version": "v0.117.0"}
2025-01-14T16:50:15.838+0100    INFO    internal/command.go:102 Using config file       {"path": "cmd/otelcontribcol/builder-config.yaml"}
2025-01-14T16:50:15.841+0100    INFO    builder/config.go:162   Using go        {"go-executable": "/usr/bin/go"}
2025-01-14T16:50:15.857+0100    INFO    builder/main.go:99      Sources created {"path": "cmd/otelcontribcol"}
2025-01-14T16:50:16.332+0100    INFO    builder/main.go:190     Getting go modules
2025-01-14T16:50:16.465+0100    INFO    builder/main.go:106     Generating source codes only, the distribution will not be compiled.
cd ./cmd/otelcontribcol && GO111MODULE=on CGO_ENABLED=0 go build -trimpath -o ../../bin/otelcontribcol_linux_amd64 \
        -tags "" .
        
# github.com/opencontainers/runc/libcontainer/cgroups/ebpf
.go/pkg/mod/github.com/opencontainers/runc@v1.1.14/libcontainer/cgroups/ebpf/ebpf_linux.go:190:3: unknown field Replace in struct literal of type link.RawAttachProgramOptions
make: *** [Makefile:352: otelcontribcol] Error 1

This is due the github.com/containerd/cgroups/v3 v3.0.5 dependency added by the integration tests file. Although this dependency is not used on the final binary, it collides with other componen's (awscontainerinsightreceiver/cadvisor) imports.

  1. To prevent this kind of issues we could do something similar to what opentelemetry-go-contrib is doing and move the tests to a submodule.

  2. Get rid of the cgroups dependency

@crobert-1
Copy link
Member

Removing needs triage as it makes sense to me and was filed by a code owner.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 14, 2025
@luistilingue
Copy link

It'll going to be awesome has such extension available in contrib distribution.

dmitryax pushed a commit that referenced this issue Apr 7, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds the cgroupruntime extension to the builder manifest so it can be
added to the k8s and contrib distributions.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
#37201

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Copy link
Contributor

github-actions bot commented Apr 8, 2025

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 8, 2025
@rogercoll
Copy link
Contributor Author

Done #39202

dmathieu pushed a commit to dmathieu/opentelemetry-collector-contrib that referenced this issue Apr 8, 2025
…etry#39202)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds the cgroupruntime extension to the builder manifest so it can be
added to the k8s and contrib distributions.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
open-telemetry#37201

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Antoine Toulme <atoulme@splunk.com>
LucianoGiannotti pushed a commit to LucianoGiannotti/opentelemetry-collector-contrib that referenced this issue Apr 9, 2025
…etry#39202)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds the cgroupruntime extension to the builder manifest so it can be
added to the k8s and contrib distributions.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
open-telemetry#37201

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this issue Apr 24, 2025
…etry#39202)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Adds the cgroupruntime extension to the builder manifest so it can be
added to the k8s and contrib distributions.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
open-telemetry#37201

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants