[processor/tailsampling] Decision cache Put() should return ok bool #37300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Porter <portertech@gmail.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
jpkrohling
approved these changes
Feb 8, 2025
jpkrohling
added
Skip Changelog
|
Given that this is an internal change and doesn't affect the behavior or interface with users of the component, changelog can be skipped for this. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Please rebase and mark ready for review if you want. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request changes the decision cache interface, updating
Put()to return an ok bool. The bool indicates if the cache put action was successful or done at all (e.g. nop). This is particularly useful when interacting with the nop cache, no longer need to follow a put w/ a get etc. This is also handy when implementing a cache that makes network calls, e.g. memcache.Related to #37035