Kafka extract header metada #24367
Merged
Kafka extract header metada #24367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MovieStoreGuy if yo can take a look at this POC |
|
^^ There's lot to do in case of readability, will address it later on after the discussion. |
frzifus
reviewed
Jul 20, 2023
|
@frzifus thanks for your review!! Does the core logic look alright to you? |
|
Just had a breef look, but at least I didn't notice anything bad 😅. Better to wait for the other reviews too. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@MovieStoreGuy ping |
MovieStoreGuy
requested changes
Aug 8, 2023
VihasMakwana
force-pushed
the
kafka-header-extract
branch
from
955afb7
to
a374e27
Compare
VihasMakwana
force-pushed
the
kafka-header-extract
branch
from
a374e27
to
d7e367f
Compare
|
VihasMakwana
force-pushed
the
kafka-header-extract
branch
from
c760392
to
f47ba3a
Compare
|
Sure. Will rebase |
|
@MovieStoreGuy I have resolved all the conflicts and merged the main. |
added 2 commits
August 23, 2023 15:06
|
@djaglowski can you have a look as well please, if it's okay for you? |
MovieStoreGuy
approved these changes
Sep 19, 2023
MovieStoreGuy
added
the
ready to merge
VihasMakwana
force-pushed
the
kafka-header-extract
branch
from
8402754
to
3514800
Compare
VihasMakwana
force-pushed
the
kafka-header-extract
branch
from
85d46a2
to
bc01580
Compare
|
@codeboten can we merge this one before the 0.86 release? it looks like an excellent feature to have. |
pavolloffay
reviewed
Sep 25, 2023
pavolloffay
approved these changes
Sep 28, 2023
evan-bradley
approved these changes
Sep 29, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** Enable support to extract headers from Kafka Messages and attach them to resource attributes. In later stages in the pipeline, different exporters can utilize this information. **Link to tracking Issue:** [21729](open-telemetry#21729) **Testing:** Added test cases for logs, traces, and metrics. **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Enable support to extract headers from Kafka Messages and attach them to resource attributes. In later stages in the pipeline, different exporters can utilize this information.
Link to tracking Issue: 21729
Testing: Added test cases for logs, traces, and metrics.
Documentation: