Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Send host metadata on change, refactor main host metadata sending #25145

Merged
merged 10 commits into from
Sep 5, 2023
Merged

[exporter/datadog] Send host metadata on change, refactor main host metadata sending #25145

merged 10 commits into from
Sep 5, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 10, 2023 •
edited
Loading

Description:

  • [*/datadog] Bump opentelemetry-mapping-go/* to v0.7.1
  • [exporter/datadog] Use reporter for exporter host as well

@mx-psi mx-psi marked this pull request as ready for review August 14, 2023 15:06
@mx-psi mx-psi requested a review from a team August 14, 2023 15:06
songy23
songy23 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM

exporter/datadogexporter/internal/hostmetadata/metadata.go
if err := pusher.Push(ctx, hostMetadata); err != nil {
params.Logger.Warn("Initial host metadata failed", zap.Error(err))
} else {
params.Logger.Info("Sent initial host metadata")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to keep this log?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have a log each time we push here: https://github.com/DataDog/opentelemetry-mapping-go/blob/8cccaf6f3cfb6e4ad31da562517c3a656f1692d7/pkg/inframetadata/reporter.go#L129-L132

exporter/datadogexporter/internal/hostmetadata/metadata.go
if err := pusher.Push(ctx, hostMetadata); err != nil {
params.Logger.Warn("Sending host metadata failed", zap.Error(err))
} else {
params.Logger.Info("Sent host metadata")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto https://github.com/DataDog/opentelemetry-mapping-go/blob/8cccaf6f3cfb6e4ad31da562517c3a656f1692d7/pkg/inframetadata/reporter.go#L129-L132

This was referenced Aug 14, 2023
Closed
Closed
Closed
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 31, 2023
@mx-psi mx-psi removed the Stale label Sep 5, 2023
@mx-psi mx-psi merged commit 5e25c8b into open-telemetry:main Sep 5, 2023
95 of 96 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@mackjmr mackjmr mackjmr approved these changes

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@dmitryax dmitryax Awaiting requested review from dmitryax

@gbbr gbbr Awaiting requested review from gbbr

@liustanley liustanley Awaiting requested review from liustanley

@pmcollins pmcollins Awaiting requested review from pmcollins

Assignees

@dashpole dashpole

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command connector/datadog exporter/datadog Datadog components internal/datadog processor/datadog
Projects
None yet
Milestone
v0.85.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mx-psi @songy23 @mackjmr @dashpole