[receiver/k8sobjects] Add ability to exclude deleted updates for watched objects #26042
Conversation
|
I noticed this receiver is using the old style of config testing which makes it difficult to add new scenarios. I plan to submit another PR to update the testing framework: #26078 |
TylerHelmuth
force-pushed
the
k8sobjects-filter-delete
branch
from
94593c3
to
c242293
Compare
| @@ -50,6 +50,7 @@ the K8s API server. This can be one of `none` (for no auth), `serviceAccount` | |||
| - `label_selector`: select objects by label(s) | |||
| - `field_selector`: select objects by field(s) | |||
| - `interval`: the interval at which object is pulled, default 60 minutes. Only useful for `pull` mode. | |||
| - `exclude_deleted`: whether the object's deleted updates should be dropped. Only usable in `watch` mode. | |||
There was a problem hiding this comment.
Why do we need to introduce a config for deleted events only? Shouldn't we have a generic configuration to limit the set of watched events?
There was a problem hiding this comment.
You're right, we could make this a generic list of accepted types, which would default to ADDED, UPDATED, and DELETED.
There was a problem hiding this comment.
Does k8s allow for custom types returned for a watch? I wouldn't want to miss any that aren't the three I mentioned.
There was a problem hiding this comment.
Does k8s allow for custom types returned for a watch? I wouldn't want to miss any that aren't the three I mentioned.
I'm not sure. @jinja2, do you know by chance?
There was a problem hiding this comment.
Maybe the best would be to have it be an exclude list and if it is empty then we exclude nothing. Then we don't have to worry about guessing what is allowed.
There was a problem hiding this comment.
https://github.com/kubernetes/apimachinery/blob/v0.28.1/pkg/watch/watch.go#L40 should be the possible types
There was a problem hiding this comment.
Ok so we can actually use the predefined EventType
There was a problem hiding this comment.
Updated to allow excluding any watch type.
|
running make gotidy cause some changes: #26314 |
| require.NotNil(t, r) | ||
| require.NoError(t, r.Start(ctx, componenttest.NewNopHost())) | ||
|
|
||
| time.Sleep(time.Millisecond * 100) |
There was a problem hiding this comment.
Perhaps an assert.Never would be better here?
There was a problem hiding this comment.
The unit tests definitely need some work, but I'd prefer to do it in a separate PR.
Description:
Adds a new configuration option that allows excluding
DELETEDupdates for watched objects.Link to tracking Issue:
Closes #24904
Testing:
New unit tests and tested locally
Documentation:
Updated the readme