Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] Extract Encoding from SplitterConfig #26511

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[pkg/stanza] Extract Encoding from SplitterConfig #26511

merged 1 commit into from
Sep 7, 2023

Conversation

djaglowski
Copy link
Member

Another small step towards decomposing the tokenize package. Part of #26241

@djaglowski djaglowski mentioned this pull request Sep 7, 2023
Merged
@djaglowski djaglowski marked this pull request as ready for review September 7, 2023 16:42
@djaglowski djaglowski requested a review from a team September 7, 2023 16:42
codeboten
codeboten approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@djaglowski djaglowski merged commit c1d70f2 into open-telemetry:main Sep 7, 2023
93 checks passed
@djaglowski djaglowski deleted the pkg-stanza-encoding-2 branch September 7, 2023 22:17
@github-actions github-actions bot added this to the next release milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

Assignees

@dashpole dashpole

Labels
pkg/stanza receiver/otlpjsonfile
Projects
None yet
Milestone
v0.85.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djaglowski @codeboten @dashpole